mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Uday Khare <udaykhare77@gmail.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] regulator: tps6594: Fix device node reference leaks in multiphase loop
Date: Thu, 18 Jun 2026 14:36:03 +0100	[thread overview]
Message-ID: <c0804d82-45a4-426b-a536-5d3369dca8a0@sirena.org.uk> (raw)
In-Reply-To: <20260618132327.11529-1-udaykhare77@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

On Thu, Jun 18, 2026 at 06:53:27PM +0530, Uday Khare wrote:
> In tps6594_regulator_probe(), the multi-phase configuration loop calls
> of_find_node_by_name() to find buck nodes by name, and of_get_parent()
> twice to navigate to the PMIC parent node. None of the acquired node
> references (np, intermediate parent, np_pmic_parent) are ever released
> via of_node_put(), causing a reference leak on every loop iteration.

You've not copied me on the rest of the series so I don't know what's
going on with dependencies.  When sending a patch series it is important
to ensure that all the various maintainers understand what the
relationship between the patches as the expecation is that there will be
interdependencies.  Either copy everyone on the whole series or at least
copy them on the cover letter and explain what's going on.  If there are
no strong interdependencies then it's generally simplest to just send
the patches separately to avoid any possible confusion.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-06-18 13:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 13:23 Uday Khare
2026-06-18 13:36 ` Mark Brown [this message]
2026-06-18 14:17   ` Uday Khare
     [not found]   ` <CAFVYD-Hq+kfe2R28HhjMHboVjt6dZDf-85CJfvMfT6BdMVKdew@mail.gmail.com>
2026-06-18 16:33     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0804d82-45a4-426b-a536-5d3369dca8a0@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=udaykhare77@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®