From: Hector Martin <marcan@marcan.st>
To: Janne Grunau <j@jannau.net>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] arm64: dts: apple: t8103: Add i2c nodes
Date: Tue, 23 Nov 2021 13:47:50 +0900 [thread overview]
Message-ID: <c0acaf72-cd86-4e92-63e5-3f903c025943@marcan.st> (raw)
In-Reply-To: <20211122225807.8105-4-j@jannau.net>
On 23/11/2021 07.58, Janne Grunau wrote:
> Apple M1 has at least 5 i2c controllers. i2c0, i2c1 and i2c3 are used
> on all M1 Mac devices. The 2020 Mac Mini uses i2c2 and the 13-inch
> MacBook Pro uses i2c2 and i2c4.
>
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> arch/arm64/boot/dts/apple/t8103-j274.dts | 4 ++
> arch/arm64/boot/dts/apple/t8103-j293.dts | 8 +++
> arch/arm64/boot/dts/apple/t8103.dtsi | 92 ++++++++++++++++++++++++
> 3 files changed, 104 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
> index c320c8baeb41..15fec48f943a 100644
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
> @@ -126,6 +126,73 @@ serial0: serial@235200000 {
> status = "disabled";
> };
>
> + i2c0: i2c@235010000 {
> + compatible = "apple,t8103-i2c", "apple,i2c";
> + reg = <0x2 0x35010000 0x0 0x4000>;
> + clocks = <&clk24>;
[...]
Please put these before serial0; I want to keep the nodes sorted by address.
With that fixed:
Acked-by: Hector Martin <marcan@marcan.st>
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
next prev parent reply other threads:[~2021-11-23 4:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 22:58 [PATCH v3 0/4] Add DTs for all Apple M1 (t8103) devices Janne Grunau
2021-11-22 22:58 ` [PATCH v3 1/4] dt-bindings: arm: apple: Add iMac (24-inch 2021) to Apple bindings Janne Grunau
2021-11-22 22:58 ` [PATCH v3 2/4] arm64: dts: apple: Add missing M1 (t8103) devices Janne Grunau
2021-11-22 22:58 ` [PATCH v3 3/4] arm64: dts: apple: t8103: Add i2c nodes Janne Grunau
2021-11-23 4:47 ` Hector Martin [this message]
2021-11-23 5:41 ` Hector Martin
2021-11-23 14:41 ` Hector Martin
2021-11-23 23:26 ` Linus Walleij
2021-11-24 5:42 ` Hector Martin
2021-11-25 15:50 ` Linus Walleij
2021-11-25 16:01 ` Hector Martin "marcan"
2021-11-23 11:46 ` Sven Peter
2021-11-22 22:58 ` [PATCH v3 4/4] arm64: dts: apple: t8103: Add cd321x nodes Janne Grunau
2021-11-23 11:56 ` Sven Peter
2021-11-26 5:38 ` Hector Martin
2021-11-26 5:39 ` [PATCH v3 0/4] Add DTs for all Apple M1 (t8103) devices Hector Martin
2021-11-26 6:33 ` Janne Grunau
2021-11-26 6:50 ` Hector Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0acaf72-cd86-4e92-63e5-3f903c025943@marcan.st \
--to=marcan@marcan.st \
--cc=alyssa@rosenzweig.io \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®