From: Hector Martin <marcan@marcan.st>
To: Janne Grunau <j@jannau.net>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] arm64: dts: apple: t8103: Add i2c nodes
Date: Tue, 23 Nov 2021 23:41:12 +0900 [thread overview]
Message-ID: <d48d2e85-42f1-570a-bd8f-e3834147c8b8@marcan.st> (raw)
In-Reply-To: <5f16c962-72a1-21ec-9651-744053f74365@marcan.st>
On 23/11/2021 14.41, Hector Martin wrote:
> On 23/11/2021 07.58, Janne Grunau wrote:
>> Apple M1 has at least 5 i2c controllers. i2c0, i2c1 and i2c3 are used
>> on all M1 Mac devices. The 2020 Mac Mini uses i2c2 and the 13-inch
>> MacBook Pro uses i2c2 and i2c4.
>
> On further testing: i2c3 is not used on the 1GbE variant of j274. iBoot
> actually kills the node entirely. The interesting thing is it doesn't
> work; it times out probe transactions. I suspect iBoot does not enable
> its clock or something like that.
>
> I'll poke around this on IRC, but a priori we probably need m1n1 code to
> kill this node when the ADT doesn't have it. Maybe I should generalize
> the dwc3 killing code...
Did that as of m1n1 be7ff3a, so we're good now :)
For those following along in the list: the reason why i2c3 was getting
stuck is because it seems the unused bus is weakly pulled low on these
machines, which jams it. Setting the GPIO pull mode to pull-up makes it
work as an empty bus, but let's just not instantiate at all in this
case. m1n1 now checks the Apple DT and sets any FDT i2c devices that are
not present in it to disabled.
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
next prev parent reply other threads:[~2021-11-23 14:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 22:58 [PATCH v3 0/4] Add DTs for all Apple M1 (t8103) devices Janne Grunau
2021-11-22 22:58 ` [PATCH v3 1/4] dt-bindings: arm: apple: Add iMac (24-inch 2021) to Apple bindings Janne Grunau
2021-11-22 22:58 ` [PATCH v3 2/4] arm64: dts: apple: Add missing M1 (t8103) devices Janne Grunau
2021-11-22 22:58 ` [PATCH v3 3/4] arm64: dts: apple: t8103: Add i2c nodes Janne Grunau
2021-11-23 4:47 ` Hector Martin
2021-11-23 5:41 ` Hector Martin
2021-11-23 14:41 ` Hector Martin [this message]
2021-11-23 23:26 ` Linus Walleij
2021-11-24 5:42 ` Hector Martin
2021-11-25 15:50 ` Linus Walleij
2021-11-25 16:01 ` Hector Martin "marcan"
2021-11-23 11:46 ` Sven Peter
2021-11-22 22:58 ` [PATCH v3 4/4] arm64: dts: apple: t8103: Add cd321x nodes Janne Grunau
2021-11-23 11:56 ` Sven Peter
2021-11-26 5:38 ` Hector Martin
2021-11-26 5:39 ` [PATCH v3 0/4] Add DTs for all Apple M1 (t8103) devices Hector Martin
2021-11-26 6:33 ` Janne Grunau
2021-11-26 6:50 ` Hector Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d48d2e85-42f1-570a-bd8f-e3834147c8b8@marcan.st \
--to=marcan@marcan.st \
--cc=alyssa@rosenzweig.io \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®