* [PATCH 1/1] arm64: defconfig: Make I2C_QCOM_GENI built-in
@ 2025-12-04 2:21 Viken Dadhaniya
2025-12-04 2:48 ` Dmitry Baryshkov
2025-12-04 7:09 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Viken Dadhaniya @ 2025-12-04 2:21 UTC (permalink / raw)
To: linux-kernel, krzk, geert+renesas, bjorn.andersson, arnd, heiko,
ebiggers, michal.simek, luca.weiss, nfraprado,
prabhakar.mahadev-lad.rj, kuninori.morimoto.gx
Cc: mukesh.savaliya, linux-arm-msm, trilok.soni, Viken Dadhaniya
Require I2C over GENI during early boot on some Qualcomm platforms to
initialize GPIO expanders that control SD card detection. Without this
driver built-in, the kernel cannot detect the root filesystem device
when modules are unavailable.
Make I2C_QCOM_GENI built-in to ensure these systems can boot without
an initramfs.
Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
---
arch/arm64/configs/defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index cdb7d69e3b24..8d85a2255b07 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -562,7 +562,7 @@ CONFIG_I2C_OMAP=y
CONFIG_I2C_OWL=y
CONFIG_I2C_PXA=y
CONFIG_I2C_QCOM_CCI=m
-CONFIG_I2C_QCOM_GENI=m
+CONFIG_I2C_QCOM_GENI=y
CONFIG_I2C_QUP=y
CONFIG_I2C_RIIC=y
CONFIG_I2C_RK3X=y
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] arm64: defconfig: Make I2C_QCOM_GENI built-in
2025-12-04 2:21 [PATCH 1/1] arm64: defconfig: Make I2C_QCOM_GENI built-in Viken Dadhaniya
@ 2025-12-04 2:48 ` Dmitry Baryshkov
2025-12-04 7:09 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-12-04 2:48 UTC (permalink / raw)
To: Viken Dadhaniya
Cc: linux-kernel, krzk, geert+renesas, bjorn.andersson, arnd, heiko,
ebiggers, michal.simek, luca.weiss, nfraprado,
prabhakar.mahadev-lad.rj, kuninori.morimoto.gx, mukesh.savaliya,
linux-arm-msm, trilok.soni
On Thu, Dec 04, 2025 at 07:51:32AM +0530, Viken Dadhaniya wrote:
> Require I2C over GENI during early boot on some Qualcomm platforms to
Which "some Qualcomm platforms" are we talking about? You got that
feedback during internal review and... sadly you didn't improve your
commit message.
> initialize GPIO expanders that control SD card detection. Without this
> driver built-in, the kernel cannot detect the root filesystem device
> when modules are unavailable.
Please use initramfs to provide additional modules. Other boot-essential
drivers are also enabled as modules (CONFIG_BLK_DEV_NVME=m,
CONFIG_SCSI_UFS_QCOM=m).
>
> Make I2C_QCOM_GENI built-in to ensure these systems can boot without
> an initramfs.
>
> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
> ---
> arch/arm64/configs/defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index cdb7d69e3b24..8d85a2255b07 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -562,7 +562,7 @@ CONFIG_I2C_OMAP=y
> CONFIG_I2C_OWL=y
> CONFIG_I2C_PXA=y
> CONFIG_I2C_QCOM_CCI=m
> -CONFIG_I2C_QCOM_GENI=m
> +CONFIG_I2C_QCOM_GENI=y
> CONFIG_I2C_QUP=y
> CONFIG_I2C_RIIC=y
> CONFIG_I2C_RK3X=y
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] arm64: defconfig: Make I2C_QCOM_GENI built-in
2025-12-04 2:21 [PATCH 1/1] arm64: defconfig: Make I2C_QCOM_GENI built-in Viken Dadhaniya
2025-12-04 2:48 ` Dmitry Baryshkov
@ 2025-12-04 7:09 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-04 7:09 UTC (permalink / raw)
To: Viken Dadhaniya, linux-kernel, geert+renesas, bjorn.andersson,
arnd, heiko, ebiggers, michal.simek, luca.weiss, nfraprado,
prabhakar.mahadev-lad.rj, kuninori.morimoto.gx
Cc: mukesh.savaliya, linux-arm-msm, trilok.soni
On 04/12/2025 03:21, Viken Dadhaniya wrote:
> Require I2C over GENI during early boot on some Qualcomm platforms to
> initialize GPIO expanders that control SD card detection. Without this
> driver built-in, the kernel cannot detect the root filesystem device
> when modules are unavailable.
>
> Make I2C_QCOM_GENI built-in to ensure these systems can boot without
> an initramfs.
No, that's a strong no. All Qcom and other arm64 systems are supposed to
use initramfs for booting on defconfig.
There is no single use case for this defconfig. Maybe you are mixing it
with some product configuration...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-04 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-04 2:21 [PATCH 1/1] arm64: defconfig: Make I2C_QCOM_GENI built-in Viken Dadhaniya
2025-12-04 2:48 ` Dmitry Baryshkov
2025-12-04 7:09 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®