mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@infradead.org>
Cc: linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>,
	Stephen Zhang <starzhangzsd@gmail.com>
Subject: Re: [PATCH v2] erofs: get rid of raw bi_end_io() usage
Date: Fri, 28 Nov 2025 09:40:46 +0800	[thread overview]
Message-ID: <c0c827d8-569a-49ef-a6ac-a758744533a4@linux.alibaba.com> (raw)
In-Reply-To: <aSjzua4jp_zZ1g1o@fedora>



On 2025/11/28 08:58, Ming Lei wrote:
> On Thu, Nov 27, 2025 at 04:07:56PM +0800, Gao Xiang wrote:
>> These BIOs are actually harmless in practice, as they are all pseudo
>> BIOs and do not use advanced features like chaining.  Using the BIO
>> interface is a more friendly and unified approach for both bdev and
>> and file-backed I/Os.
>>
>> Let's use bio_endio() instead.
>>
>> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>> ---
>> v2:
>>   - call bio_endio() unconditionally in erofs_fileio_ki_complete().
> 
> bio_endio() can cover bio not submitted yet, so:
> 
> Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thank you and Christoph for review!

Thanks,
Gao Xiang

  reply	other threads:[~2025-11-28  1:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-27  8:02 [PATCH] " Gao Xiang
2025-11-27  8:07 ` [PATCH v2] " Gao Xiang
2025-11-27 14:52   ` Christoph Hellwig
2025-11-28  0:58   ` Ming Lei
2025-11-28  1:40     ` Gao Xiang [this message]
2025-11-28  1:57       ` Gao Xiang
2025-11-28 11:44   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0c827d8-569a-49ef-a6ac-a758744533a4@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=hch@infradead.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=starzhangzsd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®