From: Jonathan Cameron <jic23@kernel.org>
To: Derek Robson <robsonde@gmail.com>,
lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: iio: resolver: ad2s1210.c - style fix
Date: Sat, 4 Feb 2017 11:44:50 +0000 [thread overview]
Message-ID: <c0d83444-fe88-1f63-9150-f3a1dae0b4a8@kernel.org> (raw)
In-Reply-To: <20170204014541.30023-1-robsonde@gmail.com>
On 04/02/17 01:45, Derek Robson wrote:
> Changed symbolic permissions to octal permissions.
> Found using checkpatch
>
> Signed-off-by: Derek Robson <robsonde@gmail.com>
Applied. Thanks,
Jonathan
> ---
> drivers/staging/iio/resolver/ad2s1210.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index 6b992634f009..90b57c03609c 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -531,36 +531,36 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev,
> return ret;
> }
>
> -static IIO_DEVICE_ATTR(fclkin, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(fclkin, 0644,
> ad2s1210_show_fclkin, ad2s1210_store_fclkin, 0);
> -static IIO_DEVICE_ATTR(fexcit, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(fexcit, 0644,
> ad2s1210_show_fexcit, ad2s1210_store_fexcit, 0);
> -static IIO_DEVICE_ATTR(control, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(control, 0644,
> ad2s1210_show_control, ad2s1210_store_control, 0);
> -static IIO_DEVICE_ATTR(bits, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(bits, 0644,
> ad2s1210_show_resolution, ad2s1210_store_resolution, 0);
> -static IIO_DEVICE_ATTR(fault, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(fault, 0644,
> ad2s1210_show_fault, ad2s1210_clear_fault, 0);
>
> -static IIO_DEVICE_ATTR(los_thrd, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(los_thrd, 0644,
> ad2s1210_show_reg, ad2s1210_store_reg,
> AD2S1210_REG_LOS_THRD);
> -static IIO_DEVICE_ATTR(dos_ovr_thrd, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(dos_ovr_thrd, 0644,
> ad2s1210_show_reg, ad2s1210_store_reg,
> AD2S1210_REG_DOS_OVR_THRD);
> -static IIO_DEVICE_ATTR(dos_mis_thrd, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(dos_mis_thrd, 0644,
> ad2s1210_show_reg, ad2s1210_store_reg,
> AD2S1210_REG_DOS_MIS_THRD);
> -static IIO_DEVICE_ATTR(dos_rst_max_thrd, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(dos_rst_max_thrd, 0644,
> ad2s1210_show_reg, ad2s1210_store_reg,
> AD2S1210_REG_DOS_RST_MAX_THRD);
> -static IIO_DEVICE_ATTR(dos_rst_min_thrd, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(dos_rst_min_thrd, 0644,
> ad2s1210_show_reg, ad2s1210_store_reg,
> AD2S1210_REG_DOS_RST_MIN_THRD);
> -static IIO_DEVICE_ATTR(lot_high_thrd, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(lot_high_thrd, 0644,
> ad2s1210_show_reg, ad2s1210_store_reg,
> AD2S1210_REG_LOT_HIGH_THRD);
> -static IIO_DEVICE_ATTR(lot_low_thrd, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(lot_low_thrd, 0644,
> ad2s1210_show_reg, ad2s1210_store_reg,
> AD2S1210_REG_LOT_LOW_THRD);
>
>
prev parent reply other threads:[~2017-02-04 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 1:45 Derek Robson
2017-02-04 11:44 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0d83444-fe88-1f63-9150-f3a1dae0b4a8@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robsonde@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®