mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "luo kaih" <kaih.luo@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] netfilter: xt_time gives a wrong monthday in a leap year
Date: Tue, 26 Aug 2008 09:03:43 +0800	[thread overview]
Message-ID: <c0ff893e0808251803tee7f145i6a5aa9f79d943dec@mail.gmail.com> (raw)

the function localtime_3 in xt_time.c  gives a wrong monthday in a
leap year after 28th 2 . calculating monthday should use the array
days_since_leapyear[] not
days_since_year[]  in a leap year .
Signed-off-by: Kaihui Luo <kaih.luo@gmail.com>
---
--- linux-2.6.26/net/netfilter/xt_time.c.orig   2008-08-25
11:59:46.000000000 +0800
+++ linux-2.6.26/net/netfilter/xt_time.c        2008-08-25
12:16:12.000000000 +0800
@@ -136,17 +136,19 @@ static void localtime_3(struct xtm *r, t
        * from w repeatedly while counting.)
        */
       if (is_leap(year)) {
+               /* use days_since_leapyear[] in a leap year */
               for (i = ARRAY_SIZE(days_since_leapyear) - 1;
-                   i > 0 && days_since_year[i] > w; --i)
+                   i > 0 && days_since_leapyear[i] > w; --i)
                       /* just loop */;
+               r->monthday = w - days_since_leapyear[i] + 1;
       } else {
               for (i = ARRAY_SIZE(days_since_year) - 1;
                   i > 0 && days_since_year[i] > w; --i)
                       /* just loop */;
+               r->monthday = w - days_since_year[i] + 1;
       }

       r->month    = i + 1;
-       r->monthday = w - days_since_year[i] + 1;
       return;
 }

                 reply	other threads:[~2008-08-26  1:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0ff893e0808251803tee7f145i6a5aa9f79d943dec@mail.gmail.com \
    --to=kaih.luo@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®