mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] netfilter: xt_time gives a wrong monthday in a leap year
@ 2008-08-26  1:03 luo kaih
  0 siblings, 0 replies; only message in thread
From: luo kaih @ 2008-08-26  1:03 UTC (permalink / raw)
  To: netfilter-devel; +Cc: trivial, linux-kernel

the function localtime_3 in xt_time.c  gives a wrong monthday in a
leap year after 28th 2 . calculating monthday should use the array
days_since_leapyear[] not
days_since_year[]  in a leap year .
Signed-off-by: Kaihui Luo <kaih.luo@gmail.com>
---
--- linux-2.6.26/net/netfilter/xt_time.c.orig   2008-08-25
11:59:46.000000000 +0800
+++ linux-2.6.26/net/netfilter/xt_time.c        2008-08-25
12:16:12.000000000 +0800
@@ -136,17 +136,19 @@ static void localtime_3(struct xtm *r, t
        * from w repeatedly while counting.)
        */
       if (is_leap(year)) {
+               /* use days_since_leapyear[] in a leap year */
               for (i = ARRAY_SIZE(days_since_leapyear) - 1;
-                   i > 0 && days_since_year[i] > w; --i)
+                   i > 0 && days_since_leapyear[i] > w; --i)
                       /* just loop */;
+               r->monthday = w - days_since_leapyear[i] + 1;
       } else {
               for (i = ARRAY_SIZE(days_since_year) - 1;
                   i > 0 && days_since_year[i] > w; --i)
                       /* just loop */;
+               r->monthday = w - days_since_year[i] + 1;
       }

       r->month    = i + 1;
-       r->monthday = w - days_since_year[i] + 1;
       return;
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-08-26  1:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-26  1:03 [PATCH] netfilter: xt_time gives a wrong monthday in a leap year luo kaih

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®