From: "André Draszik" <andre.draszik@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
kernel-team@android.com, Will McVicker <willmcvicker@google.com>,
Juan Yescas <jyescas@google.com>,
Doug Anderson <dianders@google.com>
Subject: Re: [PATCH v2 1/5] dt-bindings: clock: google,gs101-clock: fix alphanumeric ordering
Date: Tue, 13 Jan 2026 09:58:38 +0000 [thread overview]
Message-ID: <c1045dd2f33ed3a618381448717b0b5d5b28dcb5.camel@linaro.org> (raw)
In-Reply-To: <CADrjBPomC-QaL8aR4QsEPm+Uu5_QoWQZUomLMZt+09-ywH3wjA@mail.gmail.com>
Hi Peter,
On Tue, 2026-01-13 at 09:13 +0000, Peter Griffin wrote:
> Hi André,
>
> On Mon, 12 Jan 2026 at 14:26, André Draszik <andre.draszik@linaro.org> wrote:
> >
> > On Mon, 2026-01-12 at 14:16 +0000, Peter Griffin wrote:
> > > Fix the places that don't have correct alphanumeric ordering. This will
> > > make reasoning about where to add future entries more straightforward.
> > >
> > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > > ---
> > > Documentation/devicetree/bindings/clock/google,gs101-clock.yaml | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> > > b/Documentation/devicetree/bindings/clock/google,gs101-
> > > clock.yaml
> > > index 09e679c1a9def03d53b8b493929911ea902a1763..a8176687bb773ae90800b9c256bcccebfdef2e49 100644
> > > --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> > > +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> > > @@ -27,13 +27,13 @@ description: |
> > > properties:
> > > compatible:
> > > enum:
> > > - - google,gs101-cmu-top
> > > - google,gs101-cmu-apm
> > > - - google,gs101-cmu-misc
> > > - google,gs101-cmu-hsi0
> > > - google,gs101-cmu-hsi2
> > > + - google,gs101-cmu-misc
> > > - google,gs101-cmu-peric0
> > > - google,gs101-cmu-peric1
> > > + - google,gs101-cmu-top
> >
> > If we keep 'top' at the top as one outlier, it'd reflect that it is the
> > top unit and all other CMUs are children of it.
>
> Thanks for the review. I opted to just keep it alphanumeric so it's
> (hopefully) obvious what all future ordering should be.
One last comment: except that all other source files in the tree place
cmu_top at the top. It'd be more consistent with those files if done
similarly here.
Cheers,
Andre
next prev parent reply other threads:[~2026-01-13 9:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 14:16 [PATCH v2 0/5] gs101: Add support for Display Process Unit (DPU) clocks Peter Griffin
2026-01-12 14:16 ` [PATCH v2 1/5] dt-bindings: clock: google,gs101-clock: fix alphanumeric ordering Peter Griffin
2026-01-12 14:26 ` André Draszik
2026-01-13 9:13 ` Peter Griffin
2026-01-13 9:58 ` André Draszik [this message]
2026-01-13 10:01 ` Peter Griffin
2026-01-12 14:16 ` [PATCH v2 2/5] dt-bindings: clock: google,gs101-clock: Add DPU clock management unit Peter Griffin
2026-01-12 14:32 ` André Draszik
2026-01-13 9:45 ` Peter Griffin
2026-01-12 14:16 ` [PATCH v2 3/5] dt-bindings: samsung: exynos-sysreg: add gs101 dpu compatible Peter Griffin
2026-01-12 14:35 ` André Draszik
2026-01-12 14:16 ` [PATCH v2 4/5] clk: samsung: gs101: add support for Display Process Unit (DPU) clocks Peter Griffin
2026-01-12 15:07 ` André Draszik
2026-01-13 10:21 ` Peter Griffin
2026-01-12 14:16 ` [PATCH v2 5/5] arm64: dts: exynos: gs101: add cmu_dpu and sysreg_dpu dt nodes Peter Griffin
2026-01-12 14:54 ` André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1045dd2f33ed3a618381448717b0b5d5b28dcb5.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®