From: "André Draszik" <andre.draszik@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
kernel-team@android.com, Will McVicker <willmcvicker@google.com>,
Juan Yescas <jyescas@google.com>,
Doug Anderson <dianders@google.com>
Subject: Re: [PATCH v2 4/5] clk: samsung: gs101: add support for Display Process Unit (DPU) clocks
Date: Mon, 12 Jan 2026 15:07:20 +0000 [thread overview]
Message-ID: <7097507636282e4613d324ff5acb74eb747d519b.camel@linaro.org> (raw)
In-Reply-To: <20260112-dpu-clocks-v2-4-bd00903fdeb9@linaro.org>
On Mon, 2026-01-12 at 14:16 +0000, Peter Griffin wrote:
> cmu_dpu is the clock management unit used for the Display Process Unit
> block. It generates clocks for image scaler, compressor etc.
>
> Add support for the muxes, dividers and gates in cmu_dpu.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> Changes in v2:
> - Update gout_dpu_dpu_pclk to gout_dpu_gpc_dpu_pclk (Peter)
> - Fix dout_dpu_busp parent (Peter)
> ---
> drivers/clk/samsung/clk-gs101.c | 283 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 283 insertions(+)
>
> diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c
> index 8551289b46eb88ec61dd1914d0fe782ae6794000..b38c6c8749aae42319d2004ff5ffbc9a19320cac 100644
> --- a/drivers/clk/samsung/clk-gs101.c
> +++ b/drivers/clk/samsung/clk-gs101.c
> @@ -25,6 +25,7 @@
> #define CLKS_NR_MISC (CLK_GOUT_MISC_XIU_D_MISC_ACLK + 1)
> #define CLKS_NR_PERIC0 (CLK_GOUT_PERIC0_SYSREG_PERIC0_PCLK + 1)
> #define CLKS_NR_PERIC1 (CLK_GOUT_PERIC1_SYSREG_PERIC1_PCLK + 1)
> +#define CLKS_NR_DPU (CLK_GOUT_DPU_SYSREG_DPU_PCLK + 1)
Between APM and HSI0 to keep alphabetic ordering :-)
>
> #define GS101_GATE_DBG_OFFSET 0x4000
> #define GS101_DRCG_EN_OFFSET 0x104
> @@ -4426,6 +4427,285 @@ static const struct samsung_cmu_info peric1_cmu_info __initconst = {
> .drcg_offset = GS101_DRCG_EN_OFFSET,
> };
>
> +/* ---- CMU_DPU ------------------------------------------------------------- */
I'll do a full review later, but this new block should also be between
existing CMU_APM and CMU_HSI0 blocks to keep alphabetic ordering.
Cheers,
Andre'
next prev parent reply other threads:[~2026-01-12 15:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 14:16 [PATCH v2 0/5] gs101: Add " Peter Griffin
2026-01-12 14:16 ` [PATCH v2 1/5] dt-bindings: clock: google,gs101-clock: fix alphanumeric ordering Peter Griffin
2026-01-12 14:26 ` André Draszik
2026-01-13 9:13 ` Peter Griffin
2026-01-13 9:58 ` André Draszik
2026-01-13 10:01 ` Peter Griffin
2026-01-12 14:16 ` [PATCH v2 2/5] dt-bindings: clock: google,gs101-clock: Add DPU clock management unit Peter Griffin
2026-01-12 14:32 ` André Draszik
2026-01-13 9:45 ` Peter Griffin
2026-01-12 14:16 ` [PATCH v2 3/5] dt-bindings: samsung: exynos-sysreg: add gs101 dpu compatible Peter Griffin
2026-01-12 14:35 ` André Draszik
2026-01-12 14:16 ` [PATCH v2 4/5] clk: samsung: gs101: add support for Display Process Unit (DPU) clocks Peter Griffin
2026-01-12 15:07 ` André Draszik [this message]
2026-01-13 10:21 ` Peter Griffin
2026-01-12 14:16 ` [PATCH v2 5/5] arm64: dts: exynos: gs101: add cmu_dpu and sysreg_dpu dt nodes Peter Griffin
2026-01-12 14:54 ` André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7097507636282e4613d324ff5acb74eb747d519b.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®