From: Robin Murphy <robin.murphy@arm.com>
To: guoren@kernel.org, palmer@dabbelt.com,
prabhakar.mahadev-lad.rj@bp.renesas.com
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
iommu@lists.linux.dev, Guo Ren <guoren@linux.alibaba.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iommu/renesas: Support riscv compile
Date: Thu, 15 Dec 2022 17:16:41 +0000 [thread overview]
Message-ID: <c10c9742-06d6-f56b-ea55-47f99b06ca32@arm.com> (raw)
In-Reply-To: <20221215073212.1966823-1-guoren@kernel.org>
On 2022-12-15 07:32, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> After riscv selects ARCH_RENESAS, we need to add ARM64 || ARM
> dependency here.
This effectively removes all the extra COMPILE_TEST coverage we've been
enjoying. FWIW I prefer Geert's suggestion to separate the real
functional dependency from implicit assumptions about ARCH_RENESAS, with
something like:
depends on ARCH_RENESAS || COMPILE_TEST
depends on !GENERIC_ATOMIC64 #for IOMMU_IO_PGTABLE_LPAE
Thanks,
Robin.
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> ---
> drivers/iommu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index dc5f7a156ff5..746b95b9f345 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -283,6 +283,7 @@ config EXYNOS_IOMMU_DEBUG
>
> config IPMMU_VMSA
> bool "Renesas VMSA-compatible IPMMU"
> + depends on ARM64 || ARM
> depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64)
> select IOMMU_API
> select IOMMU_IO_PGTABLE_LPAE
next prev parent reply other threads:[~2022-12-15 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 7:32 guoren
2022-12-15 17:16 ` Robin Murphy [this message]
2022-12-16 1:32 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c10c9742-06d6-f56b-ea55-47f99b06ca32@arm.com \
--to=robin.murphy@arm.com \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=palmer@dabbelt.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®