* [PATCH] staging: rtl8723bs: remove redundant assignment to rtStatus
@ 2019-06-17 12:47 Colin King
2019-06-17 13:08 ` Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-06-17 12:47 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable rtStatus is initialized with a value that is never read
and later it is reassigned a new value. Hence the initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 21f2365fa627..bda19769c37f 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -352,7 +352,7 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padapter)
/* */
s32 rtl8723b_FirmwareDownload(struct adapter *padapter, bool bUsedWoWLANFw)
{
- s32 rtStatus = _SUCCESS;
+ s32 rtStatus;
u8 write_fw = 0;
unsigned long fwdl_start_time;
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove redundant assignment to rtStatus
2019-06-17 12:47 [PATCH] staging: rtl8723bs: remove redundant assignment to rtStatus Colin King
@ 2019-06-17 13:08 ` Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: Colin Ian King @ 2019-06-17 13:08 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel; +Cc: kernel-janitors, linux-kernel
On 17/06/2019 13:47, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable rtStatus is initialized with a value that is never read
> and later it is reassigned a new value. Hence the initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> index 21f2365fa627..bda19769c37f 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> @@ -352,7 +352,7 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padapter)
> /* */
> s32 rtl8723b_FirmwareDownload(struct adapter *padapter, bool bUsedWoWLANFw)
> {
> - s32 rtStatus = _SUCCESS;
> + s32 rtStatus;
> u8 write_fw = 0;
> unsigned long fwdl_start_time;
> struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
>
Actually, ignore this, the driver has lots more of these that need
cleaning up, I'll send a V2 with all the fixups later.
Colin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-17 13:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 12:47 [PATCH] staging: rtl8723bs: remove redundant assignment to rtStatus Colin King
2019-06-17 13:08 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®