* [PATCH] drm/panel: sony-td4353-jdi: Enable prepare_prev_first
@ 2025-11-30 22:40 Marijn Suijten
2025-12-01 17:52 ` Doug Anderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marijn Suijten @ 2025-11-30 22:40 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov,
Douglas Anderson, Abhinav Kumar
Cc: ~postmarketos/upstreaming, Konrad Dybcio, Martin Botka,
dri-devel, linux-kernel, AngeloGioacchino Del Regno,
Jami Kettunen, Marijn Suijten
The DSI host must be enabled before our prepare function can run, which
has to send its init sequence over DSI. Without enabling the host first
the panel will not probe.
Fixes: 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset")
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
drivers/gpu/drm/panel/panel-sony-td4353-jdi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c b/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c
index 7c989b70ab51..a14c86c60d19 100644
--- a/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c
+++ b/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c
@@ -212,6 +212,8 @@ static int sony_td4353_jdi_probe(struct mipi_dsi_device *dsi)
if (ret)
return dev_err_probe(dev, ret, "Failed to get backlight\n");
+ ctx->panel.prepare_prev_first = true;
+
drm_panel_add(&ctx->panel);
ret = mipi_dsi_attach(dsi);
---
base-commit: 7d31f578f3230f3b7b33b0930b08f9afd8429817
change-id: 20251130-sony-akari-fix-panel-3f0308e3b1ac
Best regards,
--
Marijn Suijten <marijn.suijten@somainline.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: sony-td4353-jdi: Enable prepare_prev_first
2025-11-30 22:40 [PATCH] drm/panel: sony-td4353-jdi: Enable prepare_prev_first Marijn Suijten
@ 2025-12-01 17:52 ` Doug Anderson
2025-12-02 8:32 ` AngeloGioacchino Del Regno
2025-12-15 16:20 ` Doug Anderson
2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2025-12-01 17:52 UTC (permalink / raw)
To: Marijn Suijten
Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov,
Abhinav Kumar, ~postmarketos/upstreaming, Konrad Dybcio,
Martin Botka, dri-devel, linux-kernel,
AngeloGioacchino Del Regno, Jami Kettunen
Hi,
On Sun, Nov 30, 2025 at 2:40 PM Marijn Suijten
<marijn.suijten@somainline.org> wrote:
>
> The DSI host must be enabled before our prepare function can run, which
> has to send its init sequence over DSI. Without enabling the host first
> the panel will not probe.
>
> Fixes: 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset")
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> drivers/gpu/drm/panel/panel-sony-td4353-jdi.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: sony-td4353-jdi: Enable prepare_prev_first
2025-11-30 22:40 [PATCH] drm/panel: sony-td4353-jdi: Enable prepare_prev_first Marijn Suijten
2025-12-01 17:52 ` Doug Anderson
@ 2025-12-02 8:32 ` AngeloGioacchino Del Regno
2025-12-15 16:20 ` Doug Anderson
2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-12-02 8:32 UTC (permalink / raw)
To: Marijn Suijten, Neil Armstrong, Jessica Zhang, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Dmitry Baryshkov, Douglas Anderson, Abhinav Kumar
Cc: ~postmarketos/upstreaming, Konrad Dybcio, Martin Botka,
dri-devel, linux-kernel, Jami Kettunen
Il 30/11/25 23:40, Marijn Suijten ha scritto:
> The DSI host must be enabled before our prepare function can run, which
> has to send its init sequence over DSI. Without enabling the host first
> the panel will not probe.
>
> Fixes: 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset")
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: sony-td4353-jdi: Enable prepare_prev_first
2025-11-30 22:40 [PATCH] drm/panel: sony-td4353-jdi: Enable prepare_prev_first Marijn Suijten
2025-12-01 17:52 ` Doug Anderson
2025-12-02 8:32 ` AngeloGioacchino Del Regno
@ 2025-12-15 16:20 ` Doug Anderson
2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2025-12-15 16:20 UTC (permalink / raw)
To: Marijn Suijten
Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov,
Abhinav Kumar, ~postmarketos/upstreaming, Konrad Dybcio,
Martin Botka, dri-devel, linux-kernel,
AngeloGioacchino Del Regno, Jami Kettunen
Hi,
On Sun, Nov 30, 2025 at 2:40 PM Marijn Suijten
<marijn.suijten@somainline.org> wrote:
>
> The DSI host must be enabled before our prepare function can run, which
> has to send its init sequence over DSI. Without enabling the host first
> the panel will not probe.
>
> Fixes: 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset")
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> drivers/gpu/drm/panel/panel-sony-td4353-jdi.c | 2 ++
> 1 file changed, 2 insertions(+)
Pushed to drm-misc-fixes:
[1/1] drm/panel: sony-td4353-jdi: Enable prepare_prev_first
commit: 2b973ca48ff3ef1952091c8f988d7796781836c8
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-15 16:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-30 22:40 [PATCH] drm/panel: sony-td4353-jdi: Enable prepare_prev_first Marijn Suijten
2025-12-01 17:52 ` Doug Anderson
2025-12-02 8:32 ` AngeloGioacchino Del Regno
2025-12-15 16:20 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®