mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Jessica Zhang <quic_jesszhan@quicinc.com>,
	<neil.armstrong@linaro.org>, Sam Ravnborg <sam@ravnborg.org>,
	David Airlie <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>
Cc: <quic_parellan@quicinc.com>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/panel: Add prepare_prev_first flag to Visionox VTDR6130
Date: Thu, 10 Aug 2023 09:26:42 -0700	[thread overview]
Message-ID: <c183d823-81d4-6d7c-98d9-649fa4041262@quicinc.com> (raw)
In-Reply-To: <2f9a9450-438b-257d-759c-22b273a7b35d@quicinc.com>

Hi Neil

On 8/3/2023 10:19 AM, Jessica Zhang wrote:
> 
> 
> On 7/31/2023 6:00 AM, Neil Armstrong wrote:
>> Hi,
>>
>> On 26/07/2023 00:56, Jessica Zhang wrote:
>>> Due to a recent introduction of the pre_enable_prev_first bridge flag 
>>> [1],
>>> the panel driver will be probed before the DSI is enabled, causing the
>>> DCS commands to fail to send.
>>>
>>> Ensure that DSI is enabled before panel probe by setting the
>>> prepare_prev_first flag for the panel.
>>
>> Well this is specific to MSM DSI driver, it's not related at all to 
>> the panel.
> 

I dont fully agree this is a MSM DSI driver specific thing.

If the panel can send its commands in its enable() callback, then this 
flag need not be set.

When a panel sends its DCS commands in its pre_enable() callback, any 
DSI controller will need to be ON before that otherwise DCS commands 
cannot be sent.

With this in mind, may I know why is this a MSM change and not a panel 
change?

As per my discussion with Dmitry during the last sync up, we were 
aligned on this expectation.

Thanks

Abhinav

> Hi Neil,
> 
> I think there might be some confusion caused by the commit message -- 
> instead of "enabled before panel probe", it should be "enabled before 
> panel pre_enable()" as the panel on commands are sent during prepare(), 
> which is matched to bridge pre_enable().
> 
> IIRC the general rule is that the panel driver should set the 
> prepare_prev_first flag if the on commands are sent during pre_enable(), 
> so I'll keep the code change but correct the commit message if that's ok 
> with you.
> 
> Thanks,
> 

> Jessica Zhang
> 
>>
>> Neil
>>
>>>
>>> [1] commit 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first 
>>> to alter bridge init order")
>>>
>>> Fixes: 2349183d32d8 ("drm/panel: add visionox vtdr6130 DSI panel 
>>> driver")
>>> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
>>> ---
>>>   drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c 
>>> b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
>>> index bb0dfd86ea67..e1363e128e7e 100644
>>> --- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
>>> +++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
>>> @@ -296,6 +296,7 @@ static int visionox_vtdr6130_probe(struct 
>>> mipi_dsi_device *dsi)
>>>       dsi->format = MIPI_DSI_FMT_RGB888;
>>>       dsi->mode_flags = MIPI_DSI_MODE_VIDEO | 
>>> MIPI_DSI_MODE_NO_EOT_PACKET |
>>>                 MIPI_DSI_CLOCK_NON_CONTINUOUS;
>>> +    ctx->panel.prepare_prev_first = true;
>>>       drm_panel_init(&ctx->panel, dev, &visionox_vtdr6130_panel_funcs,
>>>                  DRM_MODE_CONNECTOR_DSI);
>>>
>>> ---
>>> base-commit: 28a5c036b05fc5c935cc72d76abd3589825ea9cd
>>> change-id: 20230717-visionox-vtdr-prev-first-e00ae02eec9f
>>>
>>> Best regards,
>>

  reply	other threads:[~2023-08-10 16:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 22:56 Jessica Zhang
2023-07-31 13:00 ` Neil Armstrong
2023-08-03 17:19   ` Jessica Zhang
2023-08-10 16:26     ` Abhinav Kumar [this message]
2023-08-14  8:01       ` neil.armstrong
2023-08-14 18:02         ` Abhinav Kumar
2023-08-16  7:51           ` neil.armstrong
2023-08-17 18:35             ` Dmitry Baryshkov
2023-08-18  8:25               ` neil.armstrong
2023-08-18 10:27                 ` Dmitry Baryshkov
2023-08-21 11:26                   ` Dave Stevenson
2023-08-21  8:17                 ` Maxime Ripard
2023-08-21 10:01                   ` neil.armstrong
2023-08-21 11:36                     ` Maxime Ripard
2023-08-25 18:37                     ` Jessica Zhang
2023-08-28  8:49                       ` neil.armstrong
2023-08-28 17:07                         ` Abhinav Kumar
2023-08-29  9:22                           ` neil.armstrong
2023-08-29  9:26                             ` Dmitry Baryshkov
2023-08-29 16:36                               ` Abhinav Kumar
2023-08-29 16:43                                 ` Dmitry Baryshkov
2023-08-29 17:21                                   ` Abhinav Kumar
2023-08-29 18:51                                     ` Dmitry Baryshkov
2023-08-29 19:08                                       ` Abhinav Kumar
2023-08-29 19:15                                         ` Dmitry Baryshkov
2023-08-29 19:21                                           ` Abhinav Kumar
2023-08-30  2:05                                             ` Dmitry Baryshkov
2023-08-30  3:40                                               ` Abhinav Kumar
2023-08-29 14:13                         ` Dave Stevenson
2023-08-29 20:43                           ` Abhinav Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c183d823-81d4-6d7c-98d9-649fa4041262@quicinc.com \
    --to=quic_abhinavk@quicinc.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=quic_parellan@quicinc.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®