From: Can Guo <quic_cang@quicinc.com>
To: Manivannan Sadhasivam <mani@kernel.org>, Can Guo <cang@qti.qualcomm.com>
Cc: <bvanassche@acm.org>, <stanley.chu@mediatek.com>,
<adrian.hunter@intel.com>, <beanhuo@micron.com>,
<avri.altman@wdc.com>, <junwoo80.lee@samsung.com>,
<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..."
<linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/7] scsi: ufs: ufs-qcom: Set initial PHY gear to max HS gear for HW ver 5 and newer
Date: Wed, 8 Nov 2023 16:46:03 +0800 [thread overview]
Message-ID: <c1ec8f66-6f3d-ae1c-6fca-27f4d6e91b8a@quicinc.com> (raw)
In-Reply-To: <20231108053415.GE3296@thinkpad>
Hi Mani,
On 11/8/2023 1:34 PM, Manivannan Sadhasivam wrote:
> On Mon, Nov 06, 2023 at 08:46:11PM -0800, Can Guo wrote:
>> From: Can Guo <quic_cang@quicinc.com>
>>
>> Set the initial PHY gear to max HS gear for hosts with HW ver 5 and newer.
>>
>
> How about,
>
> "For UFSHC >= 5.0, set the initial PHY gear based on the gear value returned by
> ufs_qcom_get_hs_gear(). For the rest, use the existing default value of G2."
>
It is much better, will improve in next version.
>> This patch is not changing any functionalities or logic but only a
>> preparation patch for the next patch in this series.
>>
>
> You are also moving the default phy_gear code to ufs_qcom_set_host_params(). So
> it should be mentioned in the commit message.
>
Sure.
Thanks,
Can Guo.
next prev parent reply other threads:[~2023-11-08 8:49 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 4:46 [PATCH v2 0/7] Enable HS-G5 support on SM8550 Can Guo
2023-11-07 4:46 ` [PATCH v2 1/7] scsi: ufs: host: Rename structure ufs_dev_params to ufs_host_params Can Guo
2023-11-07 19:36 ` Andrew Halaney
2023-11-08 7:44 ` Can Guo
2023-11-07 20:56 ` Bart Van Assche
2023-11-08 7:48 ` Can Guo
2023-11-07 4:46 ` [PATCH v2 2/7] scsi: ufs: ufs-qcom: Setup host power mode during init Can Guo
2023-11-07 20:14 ` Andrew Halaney
2023-11-08 7:47 ` Can Guo
2023-11-08 5:07 ` Manivannan Sadhasivam
2023-11-08 8:07 ` Can Guo
2023-11-07 4:46 ` [PATCH v2 3/7] scsi: ufs: ufs-qcom: Allow the first init start with the maximum supported gear Can Guo
2023-11-08 5:23 ` Manivannan Sadhasivam
2023-11-08 8:21 ` Can Guo
2023-11-08 8:23 ` Can Guo
2023-11-09 3:47 ` Manivannan Sadhasivam
2023-11-09 4:07 ` Can Guo
2023-11-09 7:47 ` Manivannan Sadhasivam
2023-11-07 4:46 ` [PATCH v2 4/7] scsi: ufs: ufs-qcom: Limit HS-G5 Rate-A to hosts with HW version 5 Can Guo
2023-11-08 5:25 ` Manivannan Sadhasivam
2023-11-08 8:42 ` Can Guo
2023-11-09 3:27 ` Manivannan Sadhasivam
2023-11-07 4:46 ` [PATCH v2 5/7] scsi: ufs: ufs-qcom: Set initial PHY gear to max HS gear for HW ver 5 and newer Can Guo
2023-11-08 5:34 ` Manivannan Sadhasivam
2023-11-08 8:46 ` Can Guo [this message]
2023-11-07 4:46 ` [PATCH v2 6/7] phy: qualcomm: phy-qcom-qmp-ufs: Add High Speed Gear 5 support for SM8550 Can Guo
2023-11-07 13:18 ` Dmitry Baryshkov
2023-11-08 5:49 ` Manivannan Sadhasivam
2023-11-08 6:56 ` Dmitry Baryshkov
2023-11-09 3:24 ` Manivannan Sadhasivam
2023-11-09 9:40 ` Dmitry Baryshkov
2023-11-09 10:42 ` Manivannan Sadhasivam
2023-11-09 11:00 ` Dmitry Baryshkov
2023-11-09 16:04 ` Manivannan Sadhasivam
2023-11-09 22:11 ` Dmitry Baryshkov
2023-11-10 13:18 ` Manivannan Sadhasivam
2023-11-10 14:40 ` Can Guo
2023-11-11 4:12 ` Manivannan Sadhasivam
2023-11-12 5:13 ` Can Guo
2023-11-14 6:12 ` Manivannan Sadhasivam
2023-11-14 9:15 ` Dmitry Baryshkov
2023-11-15 7:51 ` Can Guo
2023-11-08 9:19 ` Can Guo
2023-11-09 3:26 ` Manivannan Sadhasivam
2023-11-08 9:02 ` Can Guo
2023-11-10 8:47 ` neil.armstrong
2023-11-10 9:03 ` Can Guo
2023-11-10 9:17 ` neil.armstrong
2023-11-10 9:32 ` Can Guo
2023-11-10 9:35 ` neil.armstrong
2023-11-07 4:46 ` [PATCH v2 7/7] scsi: ufs: ufs-qcom: Add support for UFS device version detection Can Guo
2023-11-08 5:11 ` [PATCH v2 0/7] Enable HS-G5 support on SM8550 Manivannan Sadhasivam
2023-11-08 8:09 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1ec8f66-6f3d-ae1c-6fca-27f4d6e91b8a@quicinc.com \
--to=quic_cang@quicinc.com \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@qti.qualcomm.com \
--cc=jejb@linux.ibm.com \
--cc=junwoo80.lee@samsung.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®