From: Tom Rix <trix@redhat.com>
To: LKML <linux-kernel@vger.kernel.org>, Joe Perches <joe@perches.com>
Subject: [RFC] removing explicit #define DEBUG
Date: Sat, 9 Jan 2021 14:28:40 -0800 [thread overview]
Message-ID: <c1f4416f-95aa-0c9e-1077-182b0922c88f@redhat.com> (raw)
In-Reply-To: <X/cK8myUzKotH86j@kroah.com>
In cleaning up the printf %hh's I have found a number of files
that explicitly do a
#define DEBUG
with no comments or surrounding #ifdef CONFIG_MY_DEBUG_FEATURE/#endif
If I saw this in a review, I would assume this was leftover devel code and nak the review.
Finding and removing are pretty trival, i believe there are only around 10.
I am bringing this up because if the existing code depends on the DEBUG,
ex/ getting lucking with timing, then the change would introduce problems.
Tom
prev parent reply other threads:[~2021-01-09 22:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 3:49 [PATCH] usb: typec: Send uevent for num_altmodes update Prashant Malani
2021-01-07 9:17 ` Greg KH
2021-01-07 9:50 ` Prashant Malani
2021-01-07 10:57 ` Greg KH
2021-01-07 13:21 ` Greg KH
2021-01-09 22:28 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1f4416f-95aa-0c9e-1077-182b0922c88f@redhat.com \
--to=trix@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®