From: Randy Dunlap <rdunlap@infradead.org>
To: Jani Nikula <jani.nikula@intel.com>, linux-kernel@vger.kernel.org
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH RESEND] iopoll: fix parameter names in kernel-doc
Date: Fri, 6 Mar 2026 11:39:39 -0800 [thread overview]
Message-ID: <c1f471dd-778f-4c9c-821f-faecfcaed62b@infradead.org> (raw)
In-Reply-To: <7b4ab61091b0bd032e129e46237f707d2448ca08@intel.com>
On 3/6/26 2:31 AM, Jani Nikula wrote:
> On Thu, 05 Mar 2026, Randy Dunlap <rdunlap@infradead.org> wrote:
>> Correct the parameter names to avoid kernel-doc warnings:
>>
>> Warning: include/linux/iopoll.h:169 function parameter 'sleep_us' not
>> described in 'read_poll_timeout_atomic'
>> Warning: ../include/linux/iopoll.h:169 function parameter
>> 'sleep_before_read' not described in 'read_poll_timeout_atomic'
>
> I think the right fix is to rename the parameters instead. They're
> passed on to poll_timeout_us_atomic() where the parameters are called
> delay_us and delay_before_op, emphasizing that this is atomic i.e. no
> sleep.
OK, will do.
Thanks.
--
~Randy
prev parent reply other threads:[~2026-03-06 19:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 6:38 Randy Dunlap
2026-03-06 10:31 ` Jani Nikula
2026-03-06 19:39 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1f471dd-778f-4c9c-821f-faecfcaed62b@infradead.org \
--to=rdunlap@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®