From: Andrew Lunn <andrew@lunn.ch>
To: weishangjuan@eswincomputing.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
rmk+kernel@armlinux.org.uk, yong.liang.choong@linux.intel.com,
vladimir.oltean@nxp.com, jszhang@kernel.org,
jan.petrous@oss.nxp.com, prabhakar.mahadev-lad.rj@bp.renesas.com,
inochiama@gmail.com, boon.khai.ng@altera.com,
dfustini@tenstorrent.com, 0x1207@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, ningyu@eswincomputing.com,
linmin@eswincomputing.com, lizhi2@eswincomputing.com
Subject: Re: [PATCH v3 2/2] ethernet: eswin: Add eic7700 ethernet driver
Date: Thu, 3 Jul 2025 18:12:29 +0200 [thread overview]
Message-ID: <c212c50e-52ae-4330-8e67-792e83ab29e4@lunn.ch> (raw)
In-Reply-To: <20250703092015.1200-1-weishangjuan@eswincomputing.com>
> +/* Default delay value*/
> +#define EIC7700_DELAY_VALUE0 0x20202020
> +#define EIC7700_DELAY_VALUE1 0x96205A20
We need a better explanation of what is going on here. What do these
numbers mean?
> + dwc_priv->dly_param_1000m[0] = EIC7700_DELAY_VALUE0;
> + dwc_priv->dly_param_1000m[1] = EIC7700_DELAY_VALUE1;
> + dwc_priv->dly_param_1000m[2] = EIC7700_DELAY_VALUE0;
> + dwc_priv->dly_param_100m[0] = EIC7700_DELAY_VALUE0;
> + dwc_priv->dly_param_100m[1] = EIC7700_DELAY_VALUE1;
> + dwc_priv->dly_param_100m[2] = EIC7700_DELAY_VALUE0;
> + dwc_priv->dly_param_10m[0] = 0x0;
> + dwc_priv->dly_param_10m[1] = 0x0;
> + dwc_priv->dly_param_10m[2] = 0x0;
What are the three different values for?
> +
> + ret = of_property_read_u32(pdev->dev.of_node, "rx-internal-delay-ps",
> + &dwc_priv->rx_delay_ps);
> + if (ret)
> + dev_dbg(&pdev->dev, "can't get rx-internal-delay-ps, ret(%d).", ret);
> + else
> + has_rx_dly = true;
> +
> + ret = of_property_read_u32(pdev->dev.of_node, "tx-internal-delay-ps",
> + &dwc_priv->tx_delay_ps);
> + if (ret)
> + dev_dbg(&pdev->dev, "can't get tx-internal-delay-ps, ret(%d).", ret);
> + else
> + has_tx_dly = true;
> + if (has_rx_dly && has_tx_dly)
What if i only to set a TX delay? I want the RX delay to default to
0ps.
{
> + eic7700_set_delay(dwc_priv->rx_delay_ps, dwc_priv->tx_delay_ps,
> + &dwc_priv->dly_param_1000m[1]);
> + eic7700_set_delay(dwc_priv->rx_delay_ps, dwc_priv->tx_delay_ps,
> + &dwc_priv->dly_param_100m[1]);
> + eic7700_set_delay(dwc_priv->rx_delay_ps, dwc_priv->tx_delay_ps,
> + &dwc_priv->dly_param_10m[1]);
> + } else {
> + dev_dbg(&pdev->dev, " use default dly\n");
What is the default? It should be 0ps. So there is no point printing
this message.
Andrew
next prev parent reply other threads:[~2025-07-03 16:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 9:18 [PATCH v3 0/2] Add driver support for Eswin eic7700 SoC ethernet controller weishangjuan
2025-07-03 9:19 ` [PATCH v3 1/2] dt-bindings: ethernet: eswin: Document for EIC7700 SoC weishangjuan
2025-07-03 9:51 ` Krzysztof Kozlowski
2025-07-06 12:56 ` 韦尚娟
2025-07-15 8:54 ` 韦尚娟
2025-07-15 9:00 ` Krzysztof Kozlowski
2025-07-03 10:49 ` Rob Herring (Arm)
2025-07-03 16:02 ` Andrew Lunn
2025-07-03 9:20 ` [PATCH v3 2/2] ethernet: eswin: Add eic7700 ethernet driver weishangjuan
2025-07-03 9:53 ` Krzysztof Kozlowski
2025-07-03 12:02 ` Russell King (Oracle)
2025-07-03 16:12 ` Andrew Lunn [this message]
2025-07-07 10:09 ` 李志
2025-07-15 9:28 ` 李志
2025-07-15 13:09 ` Andrew Lunn
2025-07-21 2:40 ` 李志
2025-07-21 13:10 ` Andrew Lunn
2025-07-22 11:24 ` 李志
2025-07-22 14:07 ` Andrew Lunn
2025-07-31 8:56 ` 李志
2025-07-31 13:31 ` Andrew Lunn
2025-08-22 2:37 ` 李志
2025-08-22 3:17 ` Andrew Lunn
2025-08-22 3:26 ` 李志
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c212c50e-52ae-4330-8e67-792e83ab29e4@lunn.ch \
--to=andrew@lunn.ch \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=boon.khai.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dfustini@tenstorrent.com \
--cc=edumazet@google.com \
--cc=inochiama@gmail.com \
--cc=jan.petrous@oss.nxp.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lizhi2@eswincomputing.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=weishangjuan@eswincomputing.com \
--cc=yong.liang.choong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®