mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baokun Li <libaokun1@huawei.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: <linux-ext4@vger.kernel.org>, <adilger.kernel@dilger.ca>,
	<jack@suse.cz>, <linux-kernel@vger.kernel.org>,
	<kernel@pankajraghav.com>, <mcgrof@kernel.org>,
	<ebiggers@kernel.org>, <willy@infradead.org>,
	<yi.zhang@huawei.com>, <yangerkun@huawei.com>,
	<chengzhihao1@huawei.com>, Baokun Li <libaokun@huaweicloud.com>,
	"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH v2 00/24] ext4: enable block size larger than page size
Date: Thu, 13 Nov 2025 17:14:52 +0800	[thread overview]
Message-ID: <c244379f-71c8-4ce7-af87-1bfa6507af28@huawei.com> (raw)
In-Reply-To: <20251112152933.GC3131573@mit.edu>

On 2025-11-12 23:29, Theodore Ts'o wrote:
> On Wed, Nov 12, 2025 at 02:27:19PM +0800, Baokun Li wrote:
>> Darrick’s reply in another thread has already made a similar change,
>> so we can apply that patch first for testing.
> I'll give that a try when I have a chance.  For now, here's a test run
> using a version of my test appliance which excludes the way group for
> the config ext4/lbs, and which has a modified e2fsprogs (built from
> the latest e2fsprogs git repo) which suppresses both warnings when
> using large block sizes if the kernel has the blocksize_gt_pagesize
> feature detected.
>
> ext4/lbs: 595 tests, 6 failures, 101 skipped, 6656 seconds
>   Failures: ext4/033 generic/620 generic/759 generic/760
>   Flaky: generic/251: 60% (3/5)   generic/645: 40% (2/5)
> Totals: 619 tests, 101 skipped, 25 failures, 0 errors, 6291s
>
> Fixing all of these filures is not a blocker for getting this patchset
> upstream, but it would be nice for us to figure out the root cause for
> them, so we can decide whether it's better to exclude the tests for
> now, or whether there's an easy fix.

Thank you for your testing! I have analyzed the above failing cases, and
they are basically unrelated to this patch set. My analysis is as follows:

# generic/759 generic/760
Require CONFIG_HUGETLB_PAGE and CONFIG_HUGETLBFS enabled.

# generic/620
vdc needs at least 33G. Passed after replacing with a 2T disk. Suggest
putting this test case into exclude.

# ext4/033
1. With 64k block size, inodes_per_group=$((blksz*8)) does not hold;
2. Creating a 400+T snapshot and formatting it as a 64k ext4 filesystem
    requires more than 1T of disk space just for metadata;
3. With 64k block size ext4, when orphan file is enabled by default,
    it fails because orphan file size exceeds 8 << 20. Fixed in [1].
    [1]:
https://lore.kernel.org/r/20251113090122.2385797-1-libaokun@huaweicloud.com
After resolving the above issues, the test passes with a 2T disk. However,
since the inode number overflow is unrelated to block size, suggest putting
this test case into exclude.

# generic/645
This test checks that idmapped mounts behave correctly with complex user
namespaces. On my side the reproduction rate is very low, about 1/100.
Even before the code was merged, occasional failures also appeared in the
4k tests. Based on the test content, I think it is unrelated to LBS.


Cheers,
Baokun



  reply	other threads:[~2025-11-13  9:15 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 14:42 libaokun
2025-11-07 14:42 ` [PATCH v2 01/24] ext4: remove page offset calculation in ext4_block_zero_page_range() libaokun
2025-11-07 14:42 ` [PATCH v2 02/24] ext4: remove page offset calculation in ext4_block_truncate_page() libaokun
2025-11-07 14:42 ` [PATCH v2 03/24] ext4: remove PAGE_SIZE checks for rec_len conversion libaokun
2025-11-07 14:42 ` [PATCH v2 04/24] ext4: make ext4_punch_hole() support large block size libaokun
2025-11-10  9:35   ` Jan Kara
2025-11-07 14:42 ` [PATCH v2 05/24] ext4: enable DIOREAD_NOLOCK by default for BS > PS as well libaokun
2025-11-07 14:42 ` [PATCH v2 06/24] ext4: introduce s_min_folio_order for future BS > PS support libaokun
2025-11-10 12:09   ` Pankaj Raghav
2025-11-07 14:42 ` [PATCH v2 07/24] ext4: support large block size in ext4_calculate_overhead() libaokun
2025-11-10  9:36   ` Jan Kara
2025-11-07 14:42 ` [PATCH v2 08/24] ext4: support large block size in ext4_readdir() libaokun
2025-11-10 12:26   ` Pankaj Raghav
2025-11-10 13:53     ` Baokun Li
2025-11-07 14:42 ` [PATCH v2 09/24] ext4: add EXT4_LBLK_TO_B macro for logical block to bytes conversion libaokun
2025-11-07 14:42 ` [PATCH v2 10/24] ext4: add EXT4_LBLK_TO_PG and EXT4_PG_TO_LBLK for block/page conversion libaokun
2025-11-10  9:37   ` Jan Kara
2025-11-07 14:42 ` [PATCH v2 11/24] ext4: support large block size in ext4_mb_load_buddy_gfp() libaokun
2025-11-07 14:42 ` [PATCH v2 12/24] ext4: support large block size in ext4_mb_get_buddy_page_lock() libaokun
2025-11-07 14:42 ` [PATCH v2 13/24] ext4: support large block size in ext4_mb_init_cache() libaokun
2025-11-07 14:42 ` [PATCH v2 14/24] ext4: prepare buddy cache inode for BS > PS with large folios libaokun
2025-11-07 14:42 ` [PATCH v2 15/24] ext4: rename 'page' references to 'folio' in multi-block allocator libaokun
2025-11-07 14:42 ` [PATCH v2 16/24] ext4: support large block size in ext4_mpage_readpages() libaokun
2025-11-07 14:42 ` [PATCH v2 17/24] ext4: support large block size in ext4_block_write_begin() libaokun
2025-11-07 14:42 ` [PATCH v2 18/24] ext4: support large block size in mpage_map_and_submit_buffers() libaokun
2025-11-07 14:42 ` [PATCH v2 19/24] ext4: support large block size in mpage_prepare_extent_to_map() libaokun
2025-11-07 14:42 ` [PATCH v2 20/24] ext4: support large block size in __ext4_block_zero_page_range() libaokun
2025-11-07 14:42 ` [PATCH v2 21/24] ext4: make data=journal support large block size libaokun
2025-11-10  9:48   ` Jan Kara
2025-11-10 11:53     ` Baokun Li
2025-11-07 14:42 ` [PATCH v2 22/24] ext4: support verifying data from large folios with fs-verity libaokun
2025-11-10  9:54   ` Jan Kara
2025-11-10 12:08     ` Baokun Li
2025-11-07 14:42 ` [PATCH v2 23/24] ext4: add checks for large folio incompatibilities when BS > PS libaokun
2025-11-10  9:59   ` Jan Kara
2025-11-07 14:42 ` [PATCH v2 24/24] ext4: enable block size larger than page size libaokun
2025-11-10 10:00   ` Jan Kara
2025-11-10 12:51   ` Pankaj Raghav
2025-11-10 15:23     ` Theodore Ts'o
2025-11-11  3:31     ` Baokun Li
2025-11-10 15:16   ` Theodore Ts'o
2025-11-11  3:43     ` Baokun Li
2025-11-10  4:32 ` [PATCH v2 00/24] " Theodore Ts'o
2025-11-10  6:18   ` Baokun Li
2025-11-10 15:34   ` Pankaj Raghav
2025-11-10 17:40     ` Theodore Ts'o
2025-11-11 23:54 ` Theodore Ts'o
2025-11-12  2:19   ` Baokun Li
2025-11-12  4:02     ` Theodore Ts'o
2025-11-12  5:23       ` Darrick J. Wong
2025-11-12  6:27       ` Baokun Li
2025-11-12 15:29         ` Theodore Ts'o
2025-11-13  9:14           ` Baokun Li [this message]
2025-11-12  2:49   ` Baokun Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c244379f-71c8-4ce7-af87-1bfa6507af28@huawei.com \
    --to=libaokun1@huawei.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=chengzhihao1@huawei.com \
    --cc=djwong@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=jack@suse.cz \
    --cc=kernel@pankajraghav.com \
    --cc=libaokun@huaweicloud.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=tytso@mit.edu \
    --cc=willy@infradead.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®