* [PATCH] staging: greybus: Remove unused function 'to_fw_mgmt_connection' [not found] <20261013181707.29830-1-deaner92.ref@yahoo.com> @ 2026-10-13 18:17 ` Jeremy Dean Clifton 2026-10-13 20:12 ` Alex Elder 0 siblings, 1 reply; 3+ messages in thread From: Jeremy Dean Clifton @ 2026-10-13 18:17 UTC (permalink / raw) To: Viresh Kumar, Johan Hovold, Alex Elder, Greg Kroah-Hartman Cc: outreachy, greybus-dev, linux-staging, linux-kernel Remove unused function from greybus driver to_fw_mgmt_connection. This function is not exported or called from anywhere tree-wide. Confirmed with git grep and cscope. Signed-off-by: Jeremy Dean Clifton <deaner92@yahoo.com> --- drivers/staging/greybus/fw-core.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index 78321be80013..46b35ef55090 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -21,13 +21,6 @@ struct gb_fw_core { static struct spilib_ops *spilib_ops; -struct gb_connection *to_fw_mgmt_connection(struct device *dev) -{ - struct gb_fw_core *fw_core = dev_get_drvdata(dev); - - return fw_core->mgmt_connection; -} - static int gb_fw_spi_connection_init(struct gb_connection *connection) { int ret; -- 2.43.0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: greybus: Remove unused function 'to_fw_mgmt_connection' 2026-10-13 18:17 ` [PATCH] staging: greybus: Remove unused function 'to_fw_mgmt_connection' Jeremy Dean Clifton @ 2026-10-13 20:12 ` Alex Elder 2026-10-13 23:11 ` Jeremy Clifton 0 siblings, 1 reply; 3+ messages in thread From: Alex Elder @ 2026-10-13 20:12 UTC (permalink / raw) To: Jeremy Dean Clifton, Viresh Kumar, Johan Hovold, Alex Elder, Greg Kroah-Hartman Cc: outreachy, greybus-dev, linux-staging, linux-kernel On 10/13/26 1:17 PM, Jeremy Dean Clifton wrote: > Remove unused function from greybus driver to_fw_mgmt_connection. > > This function is not exported or called from anywhere tree-wide. > > Confirmed with git grep and cscope. > > Signed-off-by: Jeremy Dean Clifton <deaner92@yahoo.com> Looks good to me. Are there other unused functions like this? Reviewed-by: Alex Elder <elder@riscstar.com> > --- > drivers/staging/greybus/fw-core.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c > index 78321be80013..46b35ef55090 100644 > --- a/drivers/staging/greybus/fw-core.c > +++ b/drivers/staging/greybus/fw-core.c > @@ -21,13 +21,6 @@ struct gb_fw_core { > > static struct spilib_ops *spilib_ops; > > -struct gb_connection *to_fw_mgmt_connection(struct device *dev) > -{ > - struct gb_fw_core *fw_core = dev_get_drvdata(dev); > - > - return fw_core->mgmt_connection; > -} > - > static int gb_fw_spi_connection_init(struct gb_connection *connection) > { > int ret; ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: greybus: Remove unused function 'to_fw_mgmt_connection' 2026-10-13 20:12 ` Alex Elder @ 2026-10-13 23:11 ` Jeremy Clifton 0 siblings, 0 replies; 3+ messages in thread From: Jeremy Clifton @ 2026-10-13 23:11 UTC (permalink / raw) To: Alex Elder, Viresh Kumar, Johan Hovold, Alex Elder, Greg Kroah-Hartman Cc: outreachy, greybus-dev, linux-staging, linux-kernel On 10/13/26 2:12 PM, Alex Elder wrote: > On 10/13/26 1:17 PM, Jeremy Dean Clifton wrote: >> Remove unused function from greybus driver to_fw_mgmt_connection. >> >> This function is not exported or called from anywhere tree-wide. >> >> Confirmed with git grep and cscope. >> >> Signed-off-by: Jeremy Dean Clifton <deaner92@yahoo.com> > > Looks good to me. Are there other unused functions > like this? > I did not find any others like this one. There may be some in rtl. I think that is going away soon, though. > Reviewed-by: Alex Elder <elder@riscstar.com> Thank you >> --- >> drivers/staging/greybus/fw-core.c | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/ >> greybus/fw-core.c >> index 78321be80013..46b35ef55090 100644 >> --- a/drivers/staging/greybus/fw-core.c >> +++ b/drivers/staging/greybus/fw-core.c >> @@ -21,13 +21,6 @@ struct gb_fw_core { >> static struct spilib_ops *spilib_ops; >> -struct gb_connection *to_fw_mgmt_connection(struct device *dev) >> -{ >> - struct gb_fw_core *fw_core = dev_get_drvdata(dev); >> - >> - return fw_core->mgmt_connection; >> -} >> - >> static int gb_fw_spi_connection_init(struct gb_connection *connection) >> { >> int ret; > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-13 23:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20261013181707.29830-1-deaner92.ref@yahoo.com>
2026-10-13 18:17 ` [PATCH] staging: greybus: Remove unused function 'to_fw_mgmt_connection' Jeremy Dean Clifton
2026-10-13 20:12 ` Alex Elder
2026-10-13 23:11 ` Jeremy Clifton
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®