* [PATCH v2] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards
@ 2026-09-19 1:24 Shuwen Bao
2026-09-20 6:36 ` [PATCH] " Suryansh Singh
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Shuwen Bao @ 2026-09-19 1:24 UTC (permalink / raw)
To: Hans de Goede, Ilpo Järvinen
Cc: Krishna Chomal, Emre Cecanpunar, Suryansh Singh, Radhey Kalra,
Kürşat Abaylı,
platform-driver-x86, linux-kernel, Shuwen Bao
The HP HyperX OMEN 16-am2xxx (DMI board 8F1C, 26C1 platform cycle,
Arrow Lake-HXR) is listed in the OMEN Command Center device
capability table with DisplayName "HyperX OMEN 16" and the
"PerformanceControl" feature, but is missing from the kernel's
omen_thermal_profile_boards whitelist. The thermal profile path is
therefore not enabled and the embedded controller keeps the CPU
pinned at the default frequency cap while running Linux.
Add 8F1C to the OMEN thermal profile board list. On this platform
the EC firmware also arms its own thermal profile revert timer (EC
offset 0x63, armed with 0x5a when performance is selected) and
switches back to the balanced profile once it expires, so also add
the board to omen_timed_thermal_profile_boards in order to have the
driver clear the timer and set the NOTIMER|TURBO flags when
switching to the performance profile. Testing further showed that
this board uses v0 commands, so also add it to
omen_thermal_profile_force_v0_boards.
Tested on a HyperX OMEN 16-am2xxx: after loading the patched hp-wmi
module the platform_profile interface is exposed, and switching to
the performance profile raises the CPU from a ~2.9 GHz (P-core) /
2.6 GHz (E-core) cap to ~4.8 GHz / ~4.3 GHz under a single-thread
load. The EC then reports the performance profile (0x31) with the
NOTIMER|TURBO flags set (0x62=0x06) and the revert timer cleared
(0x63=0x00); a plain write of the profile without those flags
instead arms the timer (0x63=0x5a) and the profile reverts to
balanced when it expires.
Signed-off-by: Shuwen Bao <baoshuwen2013@outlook.com>
---
drivers/platform/x86/hp/hp-wmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index 615b4cf6fc45..f229da54366a 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -211,6 +211,7 @@ static const char * const omen_thermal_profile_boards[] = {
"8BAD",
"8C58",
"8E41",
+ "8F1C",
};
/* DMI Board names of Omen laptops that are specifically set to be thermal
@@ -220,6 +221,7 @@ static const char * const omen_thermal_profile_boards[] = {
static const char * const omen_thermal_profile_force_v0_boards[] = {
"8607",
"8746", "8747", "8748", "8749", "874A",
+ "8F1C",
};
/* DMI board names of Omen laptops that have a thermal profile timer which will
@@ -229,6 +231,7 @@ static const char * const omen_thermal_profile_force_v0_boards[] = {
static const char * const omen_timed_thermal_profile_boards[] = {
"8A15", "8A42",
"8BAD",
+ "8F1C",
};
/* DMI Board names of Victus 16-d laptops */
--
2.53.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards
2026-09-19 1:24 [PATCH v2] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards Shuwen Bao
@ 2026-09-20 6:36 ` Suryansh Singh
2026-10-05 17:45 ` [PATCH v2] " Ilpo Järvinen
2026-10-06 4:49 ` Krishna Chomal
2 siblings, 0 replies; 6+ messages in thread
From: Suryansh Singh @ 2026-09-20 6:36 UTC (permalink / raw)
To: baoshuwen2013
Cc: emreleno, hansg, hello, ilpo.jarvinen, krishna.chomal108,
linux-kernel, platform-driver-x86, radheykalra901, technosfan14
On Sat, Sep 19, 2026 at 09:24:25 +0800, Shuwen Bao wrote:
> Add 8F1C to the OMEN thermal profile board list. On this platform
> the EC firmware also arms its own thermal profile revert timer (EC
> offset 0x63, armed with 0x5a when performance is selected) and
> switches back to the balanced profile once it expires, so also add
> the board to omen_timed_thermal_profile_boards in order to have the
> driver clear the timer and set the NOTIMER|TURBO flags when
> switching to the performance profile. Testing further showed that
> this board uses v0 commands, so also add it to
> omen_thermal_profile_force_v0_boards.
Thanks for the patch.
It is slightly unusual to see a board ID ending up in all 3 arrays.
(I believe no other board is present in the base, force v0 and
timed thermal profile simultaneously.)
But, it has been explained well in the commit message and tested,
so it is completely plausible.
Oh, and since the first revision of this patch had a corrupted
patch file (stated by the maintainer), I did apply it to check,
and it works.
LGTM.
Reviewed-by: Suryansh Singh <technosfan14@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards
2026-09-19 1:24 [PATCH v2] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards Shuwen Bao
2026-09-20 6:36 ` [PATCH] " Suryansh Singh
@ 2026-10-05 17:45 ` Ilpo Järvinen
2026-10-07 6:15 ` Shuwen Bao
2026-10-06 4:49 ` Krishna Chomal
2 siblings, 1 reply; 6+ messages in thread
From: Ilpo Järvinen @ 2026-10-05 17:45 UTC (permalink / raw)
To: Hans de Goede, Shuwen Bao
Cc: Krishna Chomal, Emre Cecanpunar, Suryansh Singh, Radhey Kalra,
Kürşat Abaylı,
platform-driver-x86, linux-kernel
On Sat, 19 Sep 2026 09:24:25 +0800, Shuwen Bao wrote:
> The HP HyperX OMEN 16-am2xxx (DMI board 8F1C, 26C1 platform cycle,
> Arrow Lake-HXR) is listed in the OMEN Command Center device
> capability table with DisplayName "HyperX OMEN 16" and the
> "PerformanceControl" feature, but is missing from the kernel's
> omen_thermal_profile_boards whitelist. The thermal profile path is
> therefore not enabled and the embedded controller keeps the CPU
> pinned at the default frequency cap while running Linux.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.
The list of commits applied:
[1/1] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards
commit: b631ab75e946ba7a4adf95ba8b2fb42e72f14e0e
--
i.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards
2026-09-19 1:24 [PATCH v2] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards Shuwen Bao
2026-09-20 6:36 ` [PATCH] " Suryansh Singh
2026-10-05 17:45 ` [PATCH v2] " Ilpo Järvinen
@ 2026-10-06 4:49 ` Krishna Chomal
2 siblings, 0 replies; 6+ messages in thread
From: Krishna Chomal @ 2026-10-06 4:49 UTC (permalink / raw)
To: Shuwen Bao
Cc: Hans de Goede, Ilpo Järvinen, Emre Cecanpunar,
Suryansh Singh, Radhey Kalra, Kürşat Abaylı,
platform-driver-x86, linux-kernel
On Sat, Sep 19, 2026 at 09:24:25AM +0800, Shuwen Bao wrote:
>The HP HyperX OMEN 16-am2xxx (DMI board 8F1C, 26C1 platform cycle,
>Arrow Lake-HXR) is listed in the OMEN Command Center device
>capability table with DisplayName "HyperX OMEN 16" and the
>"PerformanceControl" feature, but is missing from the kernel's
>omen_thermal_profile_boards whitelist. The thermal profile path is
>therefore not enabled and the embedded controller keeps the CPU
>pinned at the default frequency cap while running Linux.
>
>Add 8F1C to the OMEN thermal profile board list. On this platform
>the EC firmware also arms its own thermal profile revert timer (EC
>offset 0x63, armed with 0x5a when performance is selected) and
>switches back to the balanced profile once it expires, so also add
>the board to omen_timed_thermal_profile_boards in order to have the
>driver clear the timer and set the NOTIMER|TURBO flags when
>switching to the performance profile. Testing further showed that
>this board uses v0 commands, so also add it to
>omen_thermal_profile_force_v0_boards.
>
>Tested on a HyperX OMEN 16-am2xxx: after loading the patched hp-wmi
>module the platform_profile interface is exposed, and switching to
>the performance profile raises the CPU from a ~2.9 GHz (P-core) /
>2.6 GHz (E-core) cap to ~4.8 GHz / ~4.3 GHz under a single-thread
>load. The EC then reports the performance profile (0x31) with the
>NOTIMER|TURBO flags set (0x62=0x06) and the revert timer cleared
>(0x63=0x00); a plain write of the profile without those flags
>instead arms the timer (0x63=0x5a) and the profile reverts to
>balanced when it expires.
Hi Shuwen Bao,
I was working a patch[1] involving omen_timed_thermal_profile_boards[]
and needed some diagostic info. Would you mind attaching the acpidump
for your board 8F1C?
Thanks!
[1]: https://lore.kernel.org/platform-driver-x86/asPy5Q5wNYaMzTqJ@archlinux/#m922ff6cf9a68285d2b0f64e578fd6d2d6fa573f4
>Signed-off-by: Shuwen Bao <baoshuwen2013@outlook.com>
>---
> drivers/platform/x86/hp/hp-wmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
>index 615b4cf6fc45..f229da54366a 100644
>--- a/drivers/platform/x86/hp/hp-wmi.c
>+++ b/drivers/platform/x86/hp/hp-wmi.c
>@@ -211,6 +211,7 @@ static const char * const omen_thermal_profile_boards[] = {
> "8BAD",
> "8C58",
> "8E41",
>+ "8F1C",
> };
>
> /* DMI Board names of Omen laptops that are specifically set to be thermal
>@@ -220,6 +221,7 @@ static const char * const omen_thermal_profile_boards[] = {
> static const char * const omen_thermal_profile_force_v0_boards[] = {
> "8607",
> "8746", "8747", "8748", "8749", "874A",
>+ "8F1C",
> };
>
> /* DMI board names of Omen laptops that have a thermal profile timer which will
>@@ -229,6 +231,7 @@ static const char * const omen_thermal_profile_force_v0_boards[] = {
> static const char * const omen_timed_thermal_profile_boards[] = {
> "8A15", "8A42",
> "8BAD",
>+ "8F1C",
> };
>
> /* DMI Board names of Victus 16-d laptops */
>--
>2.53.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards
2026-10-05 17:45 ` [PATCH v2] " Ilpo Järvinen
@ 2026-10-07 6:15 ` Shuwen Bao
2026-10-07 10:11 ` Ilpo Järvinen
0 siblings, 1 reply; 6+ messages in thread
From: Shuwen Bao @ 2026-10-07 6:15 UTC (permalink / raw)
To: Hans de Goede, Ilpo Järvinen
Cc: Krishna Chomal, Emre Cecanpunar, Suryansh Singh, Radhey Kalra,
Kürşat Abaylı,
platform-driver-x86, linux-kernel
Hi Ilpo,
Following Krishna's review, I have sent a v3 of this patch which moves
board 8F1C from the thermal profile board list to
hp_wmi_feature_boards[], mapped to omen_v1_legacy_board_params:
https://lore.kernel.org/platform-driver-x86/
SI2PR04MB589508E55CCCD8E26E53E4DBA2942@SI2PR04MB5895.apcprd04.prod.outlook.com/
Since the v2 commit is currently applied in review-ilpo-next, could you
please drop it from that branch and take v3 instead? Otherwise the board
would end up listed in both places.
Sorry for the extra churn, and thanks for your time.
Best regards,
Shuwen Bao
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards
2026-10-07 6:15 ` Shuwen Bao
@ 2026-10-07 10:11 ` Ilpo Järvinen
0 siblings, 0 replies; 6+ messages in thread
From: Ilpo Järvinen @ 2026-10-07 10:11 UTC (permalink / raw)
To: Shuwen Bao
Cc: Hans de Goede, Krishna Chomal, Emre Cecanpunar, Suryansh Singh,
Radhey Kalra, Kürşat Abaylı,
platform-driver-x86, LKML
On Wed, 7 Oct 2026, Shuwen Bao wrote:
> Hi Ilpo,
>
> Following Krishna's review, I have sent a v3 of this patch which moves
> board 8F1C from the thermal profile board list to
> hp_wmi_feature_boards[], mapped to omen_v1_legacy_board_params:
>
> https://lore.kernel.org/platform-driver-x86/
> SI2PR04MB589508E55CCCD8E26E53E4DBA2942@SI2PR04MB5895.apcprd04.prod.outlook.com/
>
> Since the v2 commit is currently applied in review-ilpo-next, could you
> please drop it from that branch and take v3 instead? Otherwise the board
> would end up listed in both places.
Hi,
I've dropped the commit now but I'll process new patches later, not now.
> Sorry for the extra churn, and thanks for your time.
No problem at all, it happens all the time we need to reconsider
something to get things done the best way possible.
Thanks.
--
i.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-10-07 10:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-19 1:24 [PATCH v2] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards Shuwen Bao
2026-09-20 6:36 ` [PATCH] " Suryansh Singh
2026-10-05 17:45 ` [PATCH v2] " Ilpo Järvinen
2026-10-07 6:15 ` Shuwen Bao
2026-10-07 10:11 ` Ilpo Järvinen
2026-10-06 4:49 ` Krishna Chomal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®