From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Minda Chen <minda.chen@starfivetech.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Pawel Laszczak <pawell@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Chen <peter.chen@kernel.org>,
Roger Quadros <rogerq@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-binding: cdns,usb3: Add clock and reset
Date: Tue, 2 May 2023 22:10:05 +0200 [thread overview]
Message-ID: <c2b7fce9-0ca4-31ed-b851-cc415984add5@linaro.org> (raw)
In-Reply-To: <20230502081805.112149-2-minda.chen@starfivetech.com>
On 02/05/2023 10:18, Minda Chen wrote:
> To support generic clock and reset init in Cadence USBSS
> controller. Add clock and reset dts configuration.
s/. Add/, add/
(although still weird sentence)
>
> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
> ---
> Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 12 ++++++++++++
Also update the example or any in-tree DTS. Why existing users do not
need it? Aren't you duplicating clocks with wrapping node?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-02 20:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 8:18 [PATCH v1 0/2] Add clock and reset in cdns3 platform Minda Chen
2023-05-02 8:18 ` [PATCH v1 1/2] dt-binding: cdns,usb3: Add clock and reset Minda Chen
2023-05-02 20:08 ` Krzysztof Kozlowski
2023-05-06 1:36 ` Minda Chen
2023-05-02 20:10 ` Krzysztof Kozlowski [this message]
2023-05-06 1:34 ` Minda Chen
2023-05-02 8:18 ` [PATCH v1 2/2] usb: cdns3: cdns3-plat: Add clk and reset init Minda Chen
2023-05-04 12:45 ` Roger Quadros
2023-05-06 1:50 ` Minda Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2b7fce9-0ca4-31ed-b851-cc415984add5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=minda.chen@starfivetech.com \
--cc=p.zabel@pengutronix.de \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®