mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] regulator: pca9450: Fix LDO3OUT and LDO4OUT MASK
@ 2023-06-14 12:52 Teresa Remmet
  2023-06-19  8:48 ` Frieder Schrempf
  2023-06-19 20:23 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Teresa Remmet @ 2023-06-14 12:52 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Frieder Schrempf, Robin Gong
  Cc: linux-kernel, upstream

L3_OUT and L4_OUT Bit fields range from Bit 0:4 and thus the
mask should be 0x1F instead of 0x0F.

Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
---
 include/linux/regulator/pca9450.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/regulator/pca9450.h b/include/linux/regulator/pca9450.h
index 3c01c2bf84f5..505c908dbb81 100644
--- a/include/linux/regulator/pca9450.h
+++ b/include/linux/regulator/pca9450.h
@@ -196,11 +196,11 @@ enum {
 
 /* PCA9450_REG_LDO3_VOLT bits */
 #define LDO3_EN_MASK			0xC0
-#define LDO3OUT_MASK			0x0F
+#define LDO3OUT_MASK			0x1F
 
 /* PCA9450_REG_LDO4_VOLT bits */
 #define LDO4_EN_MASK			0xC0
-#define LDO4OUT_MASK			0x0F
+#define LDO4OUT_MASK			0x1F
 
 /* PCA9450_REG_LDO5_VOLT bits */
 #define LDO5L_EN_MASK			0xC0
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: pca9450: Fix LDO3OUT and LDO4OUT MASK
  2023-06-14 12:52 [PATCH] regulator: pca9450: Fix LDO3OUT and LDO4OUT MASK Teresa Remmet
@ 2023-06-19  8:48 ` Frieder Schrempf
  2023-06-19 20:23 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Frieder Schrempf @ 2023-06-19  8:48 UTC (permalink / raw)
  To: Teresa Remmet, Liam Girdwood, Mark Brown, Robin Gong
  Cc: linux-kernel, upstream

On 14.06.23 14:52, Teresa Remmet wrote:
> L3_OUT and L4_OUT Bit fields range from Bit 0:4 and thus the
> mask should be 0x1F instead of 0x0F.
> 
> Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: pca9450: Fix LDO3OUT and LDO4OUT MASK
  2023-06-14 12:52 [PATCH] regulator: pca9450: Fix LDO3OUT and LDO4OUT MASK Teresa Remmet
  2023-06-19  8:48 ` Frieder Schrempf
@ 2023-06-19 20:23 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2023-06-19 20:23 UTC (permalink / raw)
  To: Liam Girdwood, Frieder Schrempf, Robin Gong, Teresa Remmet
  Cc: linux-kernel, upstream

On Wed, 14 Jun 2023 14:52:40 +0200, Teresa Remmet wrote:
> L3_OUT and L4_OUT Bit fields range from Bit 0:4 and thus the
> mask should be 0x1F instead of 0x0F.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: pca9450: Fix LDO3OUT and LDO4OUT MASK
      commit: 7257d930aadcd62d1c7971ab14f3b1126356abdc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-19 20:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14 12:52 [PATCH] regulator: pca9450: Fix LDO3OUT and LDO4OUT MASK Teresa Remmet
2023-06-19  8:48 ` Frieder Schrempf
2023-06-19 20:23 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®