Re: [PATCH 1/1] subsystem: CPU FREQUENCY DRIVERS- Set cpu_load calculation on current frequency

Re: [PATCH 1/1] subsystem: CPU FREQUENCY DRIVERS- Set cpu_load calculation on current frequency

[Viresh Kumar]

Hi Newbie :)

On 3 March 2015 at 12:59, Rahul Khandelwal (Rahul Khandelwal)
<Rahul.Khandelwal@spreadtrum.com> wrote:
> From: Rahul Khandelwal <Rahul.khandelwal@spreadtrum.com>
>
>
>
> Explanation: When cpu governor fails to set the freq to target_freq, the
> cpu_load calculation is incorrect which is calculating on target_freq.
>
> The cpu_load should be calculated on the pcpu->policy->cur not on the
> target_freq, the cpu delta_time and delta_idle is calculated on current
> freq.
>
>
>
> Signed-off-by: Rahul Khandelwal <Rahul.khandelwal@spreadtrum.com>
>

Your company probably uses Microsoft exchange server (All do) and that corrupts
these mails badly.. Over that I don't know what tool you used to send the patch
as it doesn't look like 'git' for sure.. But that's not really a
problem if you do it
correctly..

>
> --- kernel/drivers/cpufreq/cpufreq_interactive.c.orig    2015-03-03
> 12:22:39.070543314 +0530

.orig ??

> +++ kernel/drivers/cpufreq/cpufreq_interactive.c          2015-03-03
> 12:22:36.210543640 +0530

And that too on interactive governor. Before sending patches to Linux kernel,
go through the rules please. Documentation/SubmittingPatches..

If you have gone through that it would have been nicer, anyway lets proceed.
You haven't rebased this on any kernel or rc release of official Linux kernel,
but on some release on Android.

Android is kept separately and interactive governor is not part of
mainline kernel.
If you want this patch to go through, you need to use gerrit to send
it to Android
guys..

RE: [PATCH 1/1] subsystem: CPU FREQUENCY DRIVERS- Set cpu_load calculation on current frequency

[Rahul Khandelwal (Rahul Khandelwal)]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2481 bytes --]

Hello Viresh,

Thank you for your reply and the information. :)

I have created the patch using the "diff -up" command, I think this way should be used to create patches as mentioned in Documentation/SubmittingPatches..
 
Could you please help me to know whether any kernel release using interactive governor ? or any way to share the patch the same in any kernel release.

Otherwise I will share the patch to Android guys.



-----Original Message-----
From: Viresh Kumar [mailto:viresh.kumar@linaro.org] 
Sent: 03 March 2015 16:17
To: Rahul Khandelwal (Rahul Khandelwal)
Cc: rjw@rjwysocki.net; akpm@linux-foundation.org; linux-kernel@vger.kernel.org; stable@vger.kernel.org
Subject: Re: [PATCH 1/1] subsystem: CPU FREQUENCY DRIVERS- Set cpu_load calculation on current frequency

Hi Newbie :)

On 3 March 2015 at 12:59, Rahul Khandelwal (Rahul Khandelwal) <Rahul.Khandelwal@spreadtrum.com> wrote:
> From: Rahul Khandelwal <Rahul.khandelwal@spreadtrum.com>
>
>
>
> Explanation: When cpu governor fails to set the freq to target_freq, 
> the cpu_load calculation is incorrect which is calculating on target_freq.
>
> The cpu_load should be calculated on the pcpu->policy->cur not on the 
> target_freq, the cpu delta_time and delta_idle is calculated on 
> current freq.
>
>
>
> Signed-off-by: Rahul Khandelwal <Rahul.khandelwal@spreadtrum.com>
>

Your company probably uses Microsoft exchange server (All do) and that corrupts these mails badly.. Over that I don't know what tool you used to send the patch as it doesn't look like 'git' for sure.. But that's not really a problem if you do it correctly..

>
> --- kernel/drivers/cpufreq/cpufreq_interactive.c.orig    2015-03-03
> 12:22:39.070543314 +0530

.orig ??

> +++ kernel/drivers/cpufreq/cpufreq_interactive.c          2015-03-03
> 12:22:36.210543640 +0530

And that too on interactive governor. Before sending patches to Linux kernel, go through the rules please. Documentation/SubmittingPatches..

If you have gone through that it would have been nicer, anyway lets proceed.
You haven't rebased this on any kernel or rc release of official Linux kernel, but on some release on Android.

Android is kept separately and interactive governor is not part of mainline kernel.
If you want this patch to go through, you need to use gerrit to send it to Android guys..
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH 1/1] subsystem: CPU FREQUENCY DRIVERS- Set cpu_load calculation on current frequency

[Viresh Kumar]

On 5 March 2015 at 10:06, Rahul Khandelwal (Rahul Khandelwal)
<Rahul.Khandelwal@spreadtrum.com> wrote:
> Hello Viresh,
>
> Thank you for your reply and the information. :)
>
> I have created the patch using the "diff -up" command, I think this way should be used to create patches as mentioned in Documentation/SubmittingPatches..

Oh, I was born after git and so never used any other way to send patches. :(

> Could you please help me to know whether any kernel release using interactive governor ? or any way to share the patch the same in any kernel release.

Its not part of the kernel, you have to get this into AOSP.

RE: [PATCH 1/1] subsystem: CPU FREQUENCY DRIVERS- Set cpu_load calculation on current frequency

[Rahul Khandelwal (Rahul Khandelwal)]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1152 bytes --]

Thanks :)



-----Original Message-----
From: Viresh Kumar [mailto:viresh.kumar@linaro.org] 
Sent: 05 March 2015 10:26
To: Rahul Khandelwal (Rahul Khandelwal)
Cc: rjw@rjwysocki.net; akpm@linux-foundation.org; linux-kernel@vger.kernel.org; stable@vger.kernel.org
Subject: Re: [PATCH 1/1] subsystem: CPU FREQUENCY DRIVERS- Set cpu_load calculation on current frequency

On 5 March 2015 at 10:06, Rahul Khandelwal (Rahul Khandelwal) <Rahul.Khandelwal@spreadtrum.com> wrote:
> Hello Viresh,
>
> Thank you for your reply and the information. :)
>
> I have created the patch using the "diff -up" command, I think this way should be used to create patches as mentioned in Documentation/SubmittingPatches..

Oh, I was born after git and so never used any other way to send patches. :(

> Could you please help me to know whether any kernel release using interactive governor ? or any way to share the patch the same in any kernel release.

Its not part of the kernel, you have to get this into AOSP.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥