[PATCH v1 0/1] Enable CMU_HSI1 for Exynos990

[PATCH v1 0/1] Enable CMU_HSI1 for Exynos990

[Umer Uddin]

Hi all.

This series enables a new clock block (CMU_HSI1) for the Exynos990
SoC. This clock block provides clocks for the DesignWare MMC
Controller, PCIE subsystem and UFS subsystem.

This patch depends on the following series:

[CMU_HSI1] https://lore.kernel.org/linux-samsung-soc/20250528105252.157533-1-umer.uddin@mentallysanemainliners.org/

Best regards,
Umer Uddin.

Umer Uddin (1):
  arm64: dts: exynos990: Add CMU_HSI1 node

 arch/arm64/boot/dts/exynos/exynos990.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

-- 
2.47.2

[PATCH v1 1/1] arm64: dts: exynos990: Add CMU_HSI1 node

[Umer Uddin]

CMU_HSI1 is a new clock controller that provides clocks for the
DesignWare MMC Controller, PCIE subsystem and UFS subsystem.

Signed-off-by: Umer Uddin <umer.uddin@mentallysanemainliners.org>
---
 arch/arm64/boot/dts/exynos/exynos990.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos990.dtsi b/arch/arm64/boot/dts/exynos/exynos990.dtsi
index dd7f99f51..4ab6e35f0 100644
--- a/arch/arm64/boot/dts/exynos/exynos990.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos990.dtsi
@@ -254,6 +254,25 @@ cmu_hsi0: clock-controller@10a00000 {
 				      "dpgtc";
 		};
 
+		cmu_hsi1: clock-controller@13000000 {
+			compatible = "samsung,exynos990-cmu-hsi1";
+			reg = <0x13000000 0x8000>;
+			#clock-cells = <1>;
+
+			clocks = <&oscclk>,
+				 <&cmu_top CLK_DOUT_CMU_HSI1_BUS>,
+				 <&cmu_top CLK_DOUT_CMU_HSI1_MMC_CARD>,
+				 <&cmu_top CLK_DOUT_CMU_HSI1_PCIE>,
+				 <&cmu_top CLK_DOUT_CMU_HSI1_UFS_CARD>,
+				 <&cmu_top CLK_DOUT_CMU_HSI1_UFS_EMBD>;
+			clock-names = "oscclk",
+				      "bus",
+				      "mmc_card",
+				      "pcie",
+				      "ufs_card",
+				      "ufs_embd";
+		};
+
 		pinctrl_hsi1: pinctrl@13040000 {
 			compatible = "samsung,exynos990-pinctrl";
 			reg = <0x13040000 0x1000>;
-- 
2.47.2

Re: [PATCH v1 0/1] Enable CMU_HSI1 for Exynos990

[Rob Herring (Arm)]

On Wed, 28 May 2025 11:58:20 +0100, Umer Uddin wrote:
> Hi all.
> 
> This series enables a new clock block (CMU_HSI1) for the Exynos990
> SoC. This clock block provides clocks for the DesignWare MMC
> Controller, PCIE subsystem and UFS subsystem.
> 
> This patch depends on the following series:
> 
> [CMU_HSI1] https://lore.kernel.org/linux-samsung-soc/20250528105252.157533-1-umer.uddin@mentallysanemainliners.org/
> 
> Best regards,
> Umer Uddin.
> 
> Umer Uddin (1):
>   arm64: dts: exynos990: Add CMU_HSI1 node
> 
>  arch/arm64/boot/dts/exynos/exynos990.dtsi | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> --
> 2.47.2
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20250528 (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/exynos/' for 20250528105821.158140-1-umer.uddin@mentallysanemainliners.org:

arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/clock-controller@13000000: failed to match any schema with compatible: ['samsung,exynos990-cmu-hsi1']
arch/arm64/boot/dts/exynos/exynos990-x1slte.dtb: /soc@0/clock-controller@13000000: failed to match any schema with compatible: ['samsung,exynos990-cmu-hsi1']
arch/arm64/boot/dts/exynos/exynos990-r8s.dtb: /soc@0/clock-controller@13000000: failed to match any schema with compatible: ['samsung,exynos990-cmu-hsi1']
arch/arm64/boot/dts/exynos/exynos990-x1s.dtb: /soc@0/clock-controller@13000000: failed to match any schema with compatible: ['samsung,exynos990-cmu-hsi1']

Re: [PATCH v1 0/1] Enable CMU_HSI1 for Exynos990

[Krzysztof Kozlowski]

On 28/05/2025 12:58, Umer Uddin wrote:
> Hi all.
> 
> This series enables a new clock block (CMU_HSI1) for the Exynos990
> SoC. This clock block provides clocks for the DesignWare MMC
> Controller, PCIE subsystem and UFS subsystem.
> 
> This patch depends on the following series:
> 
> [CMU_HSI1] https://lore.kernel.org/linux-samsung-soc/20250528105252.157533-1-umer.uddin@mentallysanemainliners.org/
> 
I think dependency was not merged (received comments), so I will drop
this from my queue. If that is not accurate, anyway please resend once
dependency is ready/merged. Patch itself looked ok.

BTW, I take clock and SoC changes, so it is fine to send DTS with clock
dependency together. DTS should not be mixed with driver code for Greg's
subsystems, preferred not to mix for netdev.

Best regards,
Krzysztof