* [PATCH] ACPI/IORT: Remove linker section for IORT entries again
@ 2018-02-07 4:11 Jia He
2018-02-07 11:41 ` Lorenzo Pieralisi
2018-02-08 7:57 ` Daniel Lezcano
0 siblings, 2 replies; 5+ messages in thread
From: Jia He @ 2018-02-07 4:11 UTC (permalink / raw)
To: linux-arch, linux-kernel, Arnd Bergmann
Cc: Lorenzo Pieralisi, Daniel Lezcano, Jia He
In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries
probing"), iort entries was removed in vmlinux.lds.h. But in
commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"),
this line was back incorrectly.
It does no harm except for adding some useless symbols, so fix it.
Signed-off-by: Jia He <hejianet@gmail.com>
---
include/asm-generic/vmlinux.lds.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 1ab0e52..58b1dab 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -589,7 +589,6 @@
IRQCHIP_OF_MATCH_TABLE() \
ACPI_PROBE_TABLE(irqchip) \
ACPI_PROBE_TABLE(timer) \
- ACPI_PROBE_TABLE(iort) \
EARLYCON_TABLE()
#define INIT_TEXT \
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ACPI/IORT: Remove linker section for IORT entries again
2018-02-07 4:11 [PATCH] ACPI/IORT: Remove linker section for IORT entries again Jia He
@ 2018-02-07 11:41 ` Lorenzo Pieralisi
2018-02-08 2:37 ` Jia He
2018-02-08 7:57 ` Daniel Lezcano
1 sibling, 1 reply; 5+ messages in thread
From: Lorenzo Pieralisi @ 2018-02-07 11:41 UTC (permalink / raw)
To: Jia He; +Cc: linux-arch, linux-kernel, Arnd Bergmann, Daniel Lezcano
On Tue, Feb 06, 2018 at 08:11:34PM -0800, Jia He wrote:
> In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries
> probing"), iort entries was removed in vmlinux.lds.h. But in
> commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"),
> this line was back incorrectly.
>
> It does no harm except for adding some useless symbols, so fix it.
>
> Signed-off-by: Jia He <hejianet@gmail.com>
> ---
> include/asm-generic/vmlinux.lds.h | 1 -
> 1 file changed, 1 deletion(-)
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Who is picking this up ?
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 1ab0e52..58b1dab 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -589,7 +589,6 @@
> IRQCHIP_OF_MATCH_TABLE() \
> ACPI_PROBE_TABLE(irqchip) \
> ACPI_PROBE_TABLE(timer) \
> - ACPI_PROBE_TABLE(iort) \
> EARLYCON_TABLE()
>
> #define INIT_TEXT \
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ACPI/IORT: Remove linker section for IORT entries again
2018-02-07 11:41 ` Lorenzo Pieralisi
@ 2018-02-08 2:37 ` Jia He
2018-02-08 13:58 ` Lorenzo Pieralisi
0 siblings, 1 reply; 5+ messages in thread
From: Jia He @ 2018-02-08 2:37 UTC (permalink / raw)
To: Lorenzo Pieralisi; +Cc: linux-arch, linux-kernel, Arnd Bergmann, Daniel Lezcano
On 2/7/2018 7:41 PM, Lorenzo Pieralisi Wrote:
> On Tue, Feb 06, 2018 at 08:11:34PM -0800, Jia He wrote:
>> In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries
>> probing"), iort entries was removed in vmlinux.lds.h. But in
>> commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"),
>> this line was back incorrectly.
>>
>> It does no harm except for adding some useless symbols, so fix it.
>>
>> Signed-off-by: Jia He <hejianet@gmail.com>
forget to add another Signed-off-by line(because of my company's
opensource rules)
Signed-off-by: Jia He <jia.he@hxt-semitech.com>
>> ---
>> include/asm-generic/vmlinux.lds.h | 1 -
>> 1 file changed, 1 deletion(-)
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>
> Who is picking this up ?
Sorry, do you mean who is picking up acpi/iort subsystem?
I can't answer this question. I find this minor bug while doing the code
review.
Cheers,
Jia
>> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
>> index 1ab0e52..58b1dab 100644
>> --- a/include/asm-generic/vmlinux.lds.h
>> +++ b/include/asm-generic/vmlinux.lds.h
>> @@ -589,7 +589,6 @@
>> IRQCHIP_OF_MATCH_TABLE() \
>> ACPI_PROBE_TABLE(irqchip) \
>> ACPI_PROBE_TABLE(timer) \
>> - ACPI_PROBE_TABLE(iort) \
>> EARLYCON_TABLE()
>>
>> #define INIT_TEXT \
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ACPI/IORT: Remove linker section for IORT entries again
2018-02-08 2:37 ` Jia He
@ 2018-02-08 13:58 ` Lorenzo Pieralisi
0 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Pieralisi @ 2018-02-08 13:58 UTC (permalink / raw)
To: Jia He; +Cc: linux-arch, linux-kernel, Arnd Bergmann, Daniel Lezcano
On Thu, Feb 08, 2018 at 10:37:54AM +0800, Jia He wrote:
>
>
> On 2/7/2018 7:41 PM, Lorenzo Pieralisi Wrote:
> >On Tue, Feb 06, 2018 at 08:11:34PM -0800, Jia He wrote:
> >>In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries
> >>probing"), iort entries was removed in vmlinux.lds.h. But in
> >>commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"),
> >>this line was back incorrectly.
> >>
> >>It does no harm except for adding some useless symbols, so fix it.
> >>
> >>Signed-off-by: Jia He <hejianet@gmail.com>
> forget to add another Signed-off-by line(because of my company's opensource
> rules)
>
> Signed-off-by: Jia He <jia.he@hxt-semitech.com>
>
> >>---
> >> include/asm-generic/vmlinux.lds.h | 1 -
> >> 1 file changed, 1 deletion(-)
> >Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> >
> >Who is picking this up ?
> Sorry, do you mean who is picking up acpi/iort subsystem?
No, I meant who (as-in me or Daniel) will merge this patch.
I will take it.
Lorenzo
> I can't answer this question. I find this minor bug while doing the code
> review.
>
> Cheers,
> Jia
> >>diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> >>index 1ab0e52..58b1dab 100644
> >>--- a/include/asm-generic/vmlinux.lds.h
> >>+++ b/include/asm-generic/vmlinux.lds.h
> >>@@ -589,7 +589,6 @@
> >> IRQCHIP_OF_MATCH_TABLE() \
> >> ACPI_PROBE_TABLE(irqchip) \
> >> ACPI_PROBE_TABLE(timer) \
> >>- ACPI_PROBE_TABLE(iort) \
> >> EARLYCON_TABLE()
> >> #define INIT_TEXT \
> >>--
> >>2.7.4
> >>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI/IORT: Remove linker section for IORT entries again
2018-02-07 4:11 [PATCH] ACPI/IORT: Remove linker section for IORT entries again Jia He
2018-02-07 11:41 ` Lorenzo Pieralisi
@ 2018-02-08 7:57 ` Daniel Lezcano
1 sibling, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2018-02-08 7:57 UTC (permalink / raw)
To: Jia He, linux-arch, linux-kernel, Arnd Bergmann; +Cc: Lorenzo Pieralisi
On 07/02/2018 05:11, Jia He wrote:
> In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries
> probing"), iort entries was removed in vmlinux.lds.h. But in
> commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"),
> this line was back incorrectly.
>
> It does no harm except for adding some useless symbols, so fix it.
>
> Signed-off-by: Jia He <hejianet@gmail.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> include/asm-generic/vmlinux.lds.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 1ab0e52..58b1dab 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -589,7 +589,6 @@
> IRQCHIP_OF_MATCH_TABLE() \
> ACPI_PROBE_TABLE(irqchip) \
> ACPI_PROBE_TABLE(timer) \
> - ACPI_PROBE_TABLE(iort) \
> EARLYCON_TABLE()
>
> #define INIT_TEXT \
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-08 13:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-07 4:11 [PATCH] ACPI/IORT: Remove linker section for IORT entries again Jia He
2018-02-07 11:41 ` Lorenzo Pieralisi
2018-02-08 2:37 ` Jia He
2018-02-08 13:58 ` Lorenzo Pieralisi
2018-02-08 7:57 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®