* [PATCH] riscv: ptdump: Replace unbounded sprintf() in dump_prot()
@ 2026-01-27 11:05 Thorsten Blum
2026-02-13 2:31 ` Paul Walmsley
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-01-27 11:05 UTC (permalink / raw)
To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Andrew Morton, Anshuman Khandual, David Hildenbrand, Dev Jain,
Josephine Pfeiffer
Cc: Thorsten Blum, linux-riscv, linux-kernel
Replace the unbounded sprintf("%s", ...) with the faster and safer
strscpy(). Replace all other sprintf() calls with the safer snprintf().
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/riscv/mm/ptdump.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/riscv/mm/ptdump.c b/arch/riscv/mm/ptdump.c
index 34299c2b231f..f4b4a9fcbbd8 100644
--- a/arch/riscv/mm/ptdump.c
+++ b/arch/riscv/mm/ptdump.c
@@ -7,6 +7,7 @@
#include <linux/init.h>
#include <linux/debugfs.h>
#include <linux/seq_file.h>
+#include <linux/string.h>
#include <linux/ptdump.h>
#include <linux/pgtable.h>
@@ -213,21 +214,21 @@ static void dump_prot(struct pg_state *st)
val = st->current_prot & pte_bits[i].mask;
if (val) {
if (pte_bits[i].mask == _PAGE_SOFT)
- sprintf(s, pte_bits[i].set, val >> 8);
+ snprintf(s, sizeof(s), pte_bits[i].set, val >> 8);
#ifdef CONFIG_64BIT
else if (pte_bits[i].mask == _PAGE_MTMASK_SVPBMT) {
if (val == _PAGE_NOCACHE_SVPBMT)
- sprintf(s, pte_bits[i].set, "NC");
+ snprintf(s, sizeof(s), pte_bits[i].set, "NC");
else if (val == _PAGE_IO_SVPBMT)
- sprintf(s, pte_bits[i].set, "IO");
+ snprintf(s, sizeof(s), pte_bits[i].set, "IO");
else
- sprintf(s, pte_bits[i].set, "??");
+ snprintf(s, sizeof(s), pte_bits[i].set, "??");
}
#endif
else
- sprintf(s, "%s", pte_bits[i].set);
+ strscpy(s, pte_bits[i].set);
} else {
- sprintf(s, "%s", pte_bits[i].clear);
+ strscpy(s, pte_bits[i].clear);
}
pt_dump_seq_printf(st->seq, " %s", s);
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] riscv: ptdump: Replace unbounded sprintf() in dump_prot()
2026-01-27 11:05 [PATCH] riscv: ptdump: Replace unbounded sprintf() in dump_prot() Thorsten Blum
@ 2026-02-13 2:31 ` Paul Walmsley
0 siblings, 0 replies; 2+ messages in thread
From: Paul Walmsley @ 2026-02-13 2:31 UTC (permalink / raw)
To: Thorsten Blum
Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Andrew Morton, Anshuman Khandual, David Hildenbrand, Dev Jain,
Josephine Pfeiffer, linux-riscv, linux-kernel
On Tue, 27 Jan 2026, Thorsten Blum wrote:
> Replace the unbounded sprintf("%s", ...) with the faster and safer
> strscpy(). Replace all other sprintf() calls with the safer snprintf().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Thanks, queued for v7.1.
- Paul
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-13 2:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-27 11:05 [PATCH] riscv: ptdump: Replace unbounded sprintf() in dump_prot() Thorsten Blum
2026-02-13 2:31 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®