* Re: [PATCH] powerpc/tau: Remove redundant parameter in alloc_workqueue() call
[not found] <4af6a7138fbd400e458352f6b384115f4adc4301.1623380367.git.fthain@linux-m68k.org>
@ 2021-06-11 6:03 ` Christophe Leroy
0 siblings, 0 replies; only message in thread
From: Christophe Leroy @ 2021-06-11 6:03 UTC (permalink / raw)
To: Finn Thain, Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras
Cc: linuxppc-dev, linux-kernel
Redundant with what ?
Do you mean superfluous ?
Le 11/06/2021 à 04:59, Finn Thain a écrit :
> This avoids an (optional) compiler warning:
>
> arch/powerpc/kernel/tau_6xx.c: In function 'TAU_init':
> arch/powerpc/kernel/tau_6xx.c:204:30: error: too many arguments for format [-Werror=format-extra-args]
> tau_workq = alloc_workqueue("tau", WQ_UNBOUND, 1, 0);
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: b1c6a0a10bfa ("powerpc/tau: Convert from timer to workqueue")
> Signed-off-by: Finn Thain <fthain@linux-m68k.org>
> ---
> arch/powerpc/kernel/tau_6xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/tau_6xx.c b/arch/powerpc/kernel/tau_6xx.c
> index 6c31af7f4fa8..b9a047d92ec0 100644
> --- a/arch/powerpc/kernel/tau_6xx.c
> +++ b/arch/powerpc/kernel/tau_6xx.c
> @@ -201,7 +201,7 @@ static int __init TAU_init(void)
> tau_int_enable = IS_ENABLED(CONFIG_TAU_INT) &&
> !strcmp(cur_cpu_spec->platform, "ppc750");
>
> - tau_workq = alloc_workqueue("tau", WQ_UNBOUND, 1, 0);
> + tau_workq = alloc_workqueue("tau", WQ_UNBOUND, 1);
> if (!tau_workq)
> return -ENOMEM;
>
>
^ permalink raw reply [flat|nested] only message in thread