* [PATCH] clk: samsung: gs101: Fix missing USI7_USI DIV clock in peric0_clk_regs
@ 2026-05-05 17:14 Kuan-Wei Chiu
2026-05-06 11:54 ` Tudor Ambarus
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kuan-Wei Chiu @ 2026-05-05 17:14 UTC (permalink / raw)
To: peter.griffin, krzk, s.nawrocki, cw00.choi, mturquette, sboyd
Cc: andre.draszik, tudor.ambarus, alim.akhtar, semen.protsenko,
wllee, hsuanting, marscheng, jserv, eleanor15x, linux-arm-kernel,
linux-samsung-soc, linux-clk, linux-kernel, visitorckw,
Kuan-Wei Chiu
In the peric0_clk_regs array, the divider register offset for USI6 was
accidentally listed twice, while the divider for USI7 was omitted.
Missing this DIV register causes the USI7 clock divider setting to be
lost and reset to its hardware default value during a suspend/resume
cycle.
Replace the duplicated USI6 DIV entry with the correct USI7 DIV
register.
Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0")
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
Build test only. Found via manual review.
Setting up an upstream kernel on hardware would probably take
considerable effort right now. Since this is an obvious typo, I'm
submitting it compile tested only.
drivers/clk/samsung/clk-gs101.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c
index d2bcd3a9daf8..b44bb31f38b3 100644
--- a/drivers/clk/samsung/clk-gs101.c
+++ b/drivers/clk/samsung/clk-gs101.c
@@ -3921,7 +3921,7 @@ static const unsigned long peric0_clk_regs[] __initconst = {
CLK_CON_DIV_DIV_CLK_PERIC0_USI4_USI,
CLK_CON_DIV_DIV_CLK_PERIC0_USI5_USI,
CLK_CON_DIV_DIV_CLK_PERIC0_USI6_USI,
- CLK_CON_DIV_DIV_CLK_PERIC0_USI6_USI,
+ CLK_CON_DIV_DIV_CLK_PERIC0_USI7_USI,
CLK_CON_DIV_DIV_CLK_PERIC0_USI8_USI,
CLK_CON_BUF_CLKBUF_PERIC0_IP,
CLK_CON_GAT_CLK_BLK_PERIC0_UID_PERIC0_CMU_PERIC0_IPCLKPORT_PCLK,
--
2.54.0.545.g6539524ca2-goog
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: samsung: gs101: Fix missing USI7_USI DIV clock in peric0_clk_regs
2026-05-05 17:14 [PATCH] clk: samsung: gs101: Fix missing USI7_USI DIV clock in peric0_clk_regs Kuan-Wei Chiu
@ 2026-05-06 11:54 ` Tudor Ambarus
2026-05-07 10:53 ` Peter Griffin
2026-05-14 16:56 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Tudor Ambarus @ 2026-05-06 11:54 UTC (permalink / raw)
To: Kuan-Wei Chiu, peter.griffin, krzk, s.nawrocki, cw00.choi,
mturquette, sboyd
Cc: andre.draszik, alim.akhtar, semen.protsenko, wllee, hsuanting,
marscheng, jserv, eleanor15x, linux-arm-kernel,
linux-samsung-soc, linux-clk, linux-kernel, visitorckw
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: samsung: gs101: Fix missing USI7_USI DIV clock in peric0_clk_regs
2026-05-05 17:14 [PATCH] clk: samsung: gs101: Fix missing USI7_USI DIV clock in peric0_clk_regs Kuan-Wei Chiu
2026-05-06 11:54 ` Tudor Ambarus
@ 2026-05-07 10:53 ` Peter Griffin
2026-05-14 16:56 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Peter Griffin @ 2026-05-07 10:53 UTC (permalink / raw)
To: Kuan-Wei Chiu
Cc: krzk, s.nawrocki, cw00.choi, mturquette, sboyd, andre.draszik,
tudor.ambarus, alim.akhtar, semen.protsenko, wllee, hsuanting,
marscheng, jserv, eleanor15x, linux-arm-kernel,
linux-samsung-soc, linux-clk, linux-kernel, visitorckw
On Tue, 5 May 2026 at 18:15, Kuan-Wei Chiu <visitorckw@gmail.com> wrote:
>
> In the peric0_clk_regs array, the divider register offset for USI6 was
> accidentally listed twice, while the divider for USI7 was omitted.
>
> Missing this DIV register causes the USI7 clock divider setting to be
> lost and reset to its hardware default value during a suspend/resume
> cycle.
>
> Replace the duplicated USI6 DIV entry with the correct USI7 DIV
> register.
>
> Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0")
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: samsung: gs101: Fix missing USI7_USI DIV clock in peric0_clk_regs
2026-05-05 17:14 [PATCH] clk: samsung: gs101: Fix missing USI7_USI DIV clock in peric0_clk_regs Kuan-Wei Chiu
2026-05-06 11:54 ` Tudor Ambarus
2026-05-07 10:53 ` Peter Griffin
@ 2026-05-14 16:56 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-14 16:56 UTC (permalink / raw)
To: peter.griffin, s.nawrocki, cw00.choi, mturquette, sboyd, Kuan-Wei Chiu
Cc: andre.draszik, tudor.ambarus, alim.akhtar, semen.protsenko,
wllee, hsuanting, marscheng, jserv, linux-arm-kernel,
linux-samsung-soc, linux-clk, linux-kernel, visitorckw,
Yu-Chun Lin
On Tue, 05 May 2026 17:14:57 +0000, Kuan-Wei Chiu wrote:
> In the peric0_clk_regs array, the divider register offset for USI6 was
> accidentally listed twice, while the divider for USI7 was omitted.
>
> Missing this DIV register causes the USI7 clock divider setting to be
> lost and reset to its hardware default value during a suspend/resume
> cycle.
>
> [...]
Applied, thanks!
[1/1] clk: samsung: gs101: Fix missing USI7_USI DIV clock in peric0_clk_regs
https://git.kernel.org/krzk/linux/c/78ee734b36284d82454e87a92094fdb926985b47
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-05-14 16:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-05 17:14 [PATCH] clk: samsung: gs101: Fix missing USI7_USI DIV clock in peric0_clk_regs Kuan-Wei Chiu
2026-05-06 11:54 ` Tudor Ambarus
2026-05-07 10:53 ` Peter Griffin
2026-05-14 16:56 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®