From: "Paul E. McKenney" <paulmck@kernel.org>
To: Ankur Arora <ankur.a.arora@oracle.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
tglx@linutronix.de, mingo@kernel.org, bigeasy@linutronix.de,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
frederic@kernel.org, efault@gmx.de, sshegde@linux.ibm.com,
boris.ostrovsky@oracle.com
Subject: Re: [PATCH v3 0/7] RCU changes for PREEMPT_LAZY
Date: Tue, 7 Jan 2025 17:14:33 -0800 [thread overview]
Message-ID: <c38ebc69-33cc-4848-bcd6-a07404d8daa2@paulmck-laptop> (raw)
In-Reply-To: <20241213040658.2282640-1-ankur.a.arora@oracle.com>
On Thu, Dec 12, 2024 at 08:06:51PM -0800, Ankur Arora wrote:
> This series adds RCU bits for lazy preemption.
>
> The problem addressed is that pre-PREEMPT_LAZY, PREEMPTION=y implied
> PREEMPT_RCU=y. With PREEMPT_LAZY, that's no longer true.
>
> That's because PREEMPT_RCU makes some trade-offs to optimize for
> latency as opposed to throughput, and configurations with limited
> preemption might prefer the stronger forward-progress guarantees of
> PREEMPT_RCU=n.
>
> Accordingly, with standalone PREEMPT_LAZY (much like PREEMPT_NONE,
> PREEMPT_VOLUNTARY) we want to use PREEMPT_RCU=n. And, when used in
> conjunction with PREEMPT_DYNAMIC, we continue to use PREEMPT_RCU=y.
>
> Patches 1-3 are cleanup patches:
> "rcu: fix header guard for rcu_all_qs()"
> "rcu: rename PREEMPT_AUTO to PREEMPT_LAZY"
> "sched: update __cond_resched comment about RCU quiescent states"
>
> Patch 4,
> "rcu: handle unstable rdp in rcu_read_unlock_strict()"
>
> handles a latent RCU bug rcu_report_qs_rdp() could be called with
> an unstable rdp.
>
> Patches 5 and 6,
> "rcu: handle quiescent states for PREEMPT_RCU=n, PREEMPT_COUNT=y"
> "osnoise: provide quiescent states"
>
> handle quiescent states for the (PREEMPT_LAZY=y, PREEMPT_RCU=n)
> configuration.
>
> And, finally patch 7, "rcu: limit PREEMPT_RCU configurations",
> explicitly limits PREEMPT_RCU=y to the PREEMPT_DYNAMIC or the latency
> oriented models.
Pulled into my -rcu tree for further review and testing, with initial
tests passing. Apologies for the delay!
Thanx, Paul
> Changelog:
>
> v3:
> - moved patch-3 to be the last one in the series (suggested by Sebastian)
> - added "rcu: handle unstable rdp in rcu_read_unlock_strict()"
> (suggested by Frederic Weisbecker).
> - switched to a more robust check in rcu_flavor_sched_clock_irq()
> (suggested by Frederic Weisbecker).
> - simplified check in osnoise (suggested by Frederic Weisbecker).
> - dropped an unrelated scheduler patch.
>
> v2:
> - fixup incorrect usage of tif_need_resched_lazy() (comment from
> from Sebastian Andrzej Siewior)
> - massaged the commit messages a bit
> - drops the powerpc support for PREEMPT_LAZY as that was orthogonal
> to this series (Shrikanth will send that out separately.)
>
> Please review.
>
> Ankur Arora (7):
> rcu: fix header guard for rcu_all_qs()
> rcu: rename PREEMPT_AUTO to PREEMPT_LAZY
> sched: update __cond_resched comment about RCU quiescent states
> rcu: handle unstable rdp in rcu_read_unlock_strict()
> rcu: handle quiescent states for PREEMPT_RCU=n, PREEMPT_COUNT=y
> osnoise: provide quiescent states
> rcu: limit PREEMPT_RCU configurations
>
> include/linux/rcupdate.h | 2 +-
> include/linux/rcutree.h | 2 +-
> include/linux/srcutiny.h | 2 +-
> kernel/rcu/Kconfig | 4 ++--
> kernel/rcu/srcutiny.c | 14 +++++++-------
> kernel/rcu/tree_plugin.h | 22 +++++++++++++++++-----
> kernel/sched/core.c | 4 +++-
> kernel/trace/trace_osnoise.c | 32 +++++++++++++++-----------------
> 8 files changed, 47 insertions(+), 35 deletions(-)
>
> --
> 2.43.5
>
next prev parent reply other threads:[~2025-01-08 1:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 4:06 Ankur Arora
2024-12-13 4:06 ` [PATCH v3 1/7] rcu: fix header guard for rcu_all_qs() Ankur Arora
2024-12-13 4:06 ` [PATCH v3 2/7] rcu: rename PREEMPT_AUTO to PREEMPT_LAZY Ankur Arora
2024-12-13 4:06 ` [PATCH v3 3/7] sched: update __cond_resched comment about RCU quiescent states Ankur Arora
2024-12-13 13:21 ` Frederic Weisbecker
2024-12-13 4:06 ` [PATCH v3 4/7] rcu: handle unstable rdp in rcu_read_unlock_strict() Ankur Arora
2024-12-13 13:38 ` Frederic Weisbecker
2024-12-13 4:06 ` [PATCH v3 5/7] rcu: handle quiescent states for PREEMPT_RCU=n, PREEMPT_COUNT=y Ankur Arora
2024-12-13 13:59 ` Frederic Weisbecker
2024-12-13 20:44 ` Ankur Arora
2024-12-13 4:06 ` [PATCH v3 6/7] osnoise: provide quiescent states Ankur Arora
2024-12-13 14:34 ` Frederic Weisbecker
2024-12-13 4:06 ` [PATCH v3 7/7] rcu: limit PREEMPT_RCU configurations Ankur Arora
2025-01-08 1:14 ` Paul E. McKenney [this message]
2025-01-08 18:18 ` [PATCH v3 0/7] RCU changes for PREEMPT_LAZY Ankur Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c38ebc69-33cc-4848-bcd6-a07404d8daa2@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=ankur.a.arora@oracle.com \
--cc=bigeasy@linutronix.de \
--cc=boris.ostrovsky@oracle.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=efault@gmx.de \
--cc=frederic@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sshegde@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®