mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] irqchip: aspeed: Add AST2500 compatible string
@ 2017-05-16  7:57 Andrew Jeffery
  2017-05-23  0:06 ` Rob Herring
  2017-06-02 10:07 ` Marc Zyngier
  0 siblings, 2 replies; 3+ messages in thread
From: Andrew Jeffery @ 2017-05-16  7:57 UTC (permalink / raw)
  To: linux-kernel
  Cc: Andrew Jeffery, devicetree, tglx, jason, marc.zyngier, robh+dt,
	mark.rutland, joel, ryan_chen

In addition to introducing the new compatible string the bindings
description is reworked to be more generic.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 .../bindings/interrupt-controller/aspeed,ast2400-vic.txt         | 9 +++++----
 drivers/irqchip/irq-aspeed-vic.c                                 | 3 ++-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
index 6c6e85324b9d..e3fea0758d25 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
@@ -1,12 +1,13 @@
 Aspeed Vectored Interrupt Controller
 
-These bindings are for the Aspeed AST2400 interrupt controller register layout.
-The SoC has an legacy register layout, but this driver does not support that
-mode of operation.
+These bindings are for the Aspeed interrupt controller. The AST2400 and
+AST2500 SoC families include a legacy register layout before a re-designed
+layout, but the bindings do not prescribe the use of one or the other.
 
 Required properties:
 
-- compatible : should be "aspeed,ast2400-vic".
+- compatible : "aspeed,ast2400-vic"
+               "aspeed,ast2500-vic"
 
 - interrupt-controller : Identifies the node as an interrupt controller
 - #interrupt-cells : Specifies the number of cells needed to encode an
diff --git a/drivers/irqchip/irq-aspeed-vic.c b/drivers/irqchip/irq-aspeed-vic.c
index d24451d5bf8a..1c908ce25a9f 100644
--- a/drivers/irqchip/irq-aspeed-vic.c
+++ b/drivers/irqchip/irq-aspeed-vic.c
@@ -227,4 +227,5 @@ static int __init avic_of_init(struct device_node *node,
 	return 0;
 }
 
-IRQCHIP_DECLARE(aspeed_new_vic, "aspeed,ast2400-vic", avic_of_init);
+IRQCHIP_DECLARE(ast2400_vic, "aspeed,ast2400-vic", avic_of_init);
+IRQCHIP_DECLARE(ast2500_vic, "aspeed,ast2500-vic", avic_of_init);
-- 
2.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] irqchip: aspeed: Add AST2500 compatible string
  2017-05-16  7:57 [PATCH] irqchip: aspeed: Add AST2500 compatible string Andrew Jeffery
@ 2017-05-23  0:06 ` Rob Herring
  2017-06-02 10:07 ` Marc Zyngier
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2017-05-23  0:06 UTC (permalink / raw)
  To: Andrew Jeffery
  Cc: linux-kernel, devicetree, tglx, jason, marc.zyngier,
	mark.rutland, joel, ryan_chen

On Tue, May 16, 2017 at 03:57:47PM +0800, Andrew Jeffery wrote:
> In addition to introducing the new compatible string the bindings
> description is reworked to be more generic.
> 
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
>  .../bindings/interrupt-controller/aspeed,ast2400-vic.txt         | 9 +++++----
>  drivers/irqchip/irq-aspeed-vic.c                                 | 3 ++-
>  2 files changed, 7 insertions(+), 5 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] irqchip: aspeed: Add AST2500 compatible string
  2017-05-16  7:57 [PATCH] irqchip: aspeed: Add AST2500 compatible string Andrew Jeffery
  2017-05-23  0:06 ` Rob Herring
@ 2017-06-02 10:07 ` Marc Zyngier
  1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2017-06-02 10:07 UTC (permalink / raw)
  To: Andrew Jeffery, linux-kernel
  Cc: devicetree, tglx, jason, robh+dt, mark.rutland, joel, ryan_chen

On 16/05/17 08:57, Andrew Jeffery wrote:
> In addition to introducing the new compatible string the bindings
> description is reworked to be more generic.
> 
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Queued for 4.13.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-02 10:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-16  7:57 [PATCH] irqchip: aspeed: Add AST2500 compatible string Andrew Jeffery
2017-05-23  0:06 ` Rob Herring
2017-06-02 10:07 ` Marc Zyngier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®