From: Thomas Hellstrom <thellstrom@vmware.com>
To: Julian Calaby <julian.calaby@gmail.com>, Joe Perches <joe@perches.com>
Cc: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
"pv-drivers@vmware.com" <pv-drivers@vmware.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jim Gill <jgill@vmware.com>
Subject: Re: [Pv-drivers] [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Date: Fri, 17 Jun 2016 09:55:39 +0200 [thread overview]
Message-ID: <c398095a-4608-06ce-ceb1-f0aaaf12d426@vmware.com> (raw)
In-Reply-To: <CAGRGNgXGxFdzE4fdEzr2iPRX0DPN9JNZcC8HNTt-jW6iNyMqnQ@mail.gmail.com>
Hi!
IMO we shouldn't have maintainer info mentioned in the source files,
since the information is redundant and moreover if we change maintainer
a patch touching multiple files would just look odd, and we'd leave a
lot of stale info in older kernels.
Having the linux git *master* MAINTAINERS file as the authoritative
information source for this makes most sense. If there are different
maintainers of different parts of a single module we should be able to
sort that out internally.
Thanks,
Thomas
On 06/17/2016 05:11 AM, Julian Calaby wrote:
> Hi Joe,
>
> On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches <joe@perches.com> wrote:
>> On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote:
>>> Hi Joe,
>> rehi Julian.
> (I always put a salutation on my emails and always finish them with
> "Thanks," =) )
>
>>> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
>> []
>>>> get_maintainer.pl also has a rarely used "--file-emails" option to
>>>> scan for what appears to be email addresses in specific files.
>>>>
>>>> $ ./scripts/get_maintainer.pl -f --file-emails drivers/scsi/vmw_pvscsi.c
>>>> Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
>>>> VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
>>>> "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
>>>> "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
>>>> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
>>>> linux-kernel@vger.kernel.org (open list)
>>>>
>>>> note the "in file" after Arvind's name
>>> Didn't know this, however my point stands: the maintainer line in the
>>> file is redundant if we find maintainers through MAINTAINERS or the
>>> get_maintainer.pl script.
>> Yes, I'm not suggesting anything else. Jim's name
>> should appear in the MAINTAINERS file somewhere.
>>
>> The question to me is whether or not Jim Gill is
>> taking over the maintainership of the entire
>> VMware PVSCSI driver or just a few files of it.
> As I see it, he's taking over maintainership of all of it: it's only
> files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.
>
> Thanks,
>
next prev parent reply other threads:[~2016-06-17 8:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 1:05 Jim Gill
2016-06-17 1:19 ` Arvind Kumar
2016-06-17 1:48 ` Julian Calaby
2016-06-17 2:03 ` Arvind Kumar
2016-06-17 2:18 ` Julian Calaby
2016-06-17 2:33 ` Joe Perches
2016-06-17 2:44 ` Julian Calaby
2016-06-17 3:04 ` Joe Perches
2016-06-17 3:11 ` Julian Calaby
2016-06-17 7:55 ` Thomas Hellstrom [this message]
2016-06-17 17:44 ` Jim Gill
2016-06-17 18:06 ` Joe Perches
2016-06-17 18:16 ` Jim Gill
2016-06-21 2:01 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c398095a-4608-06ce-ceb1-f0aaaf12d426@vmware.com \
--to=thellstrom@vmware.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jgill@vmware.com \
--cc=joe@perches.com \
--cc=julian.calaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®