mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	robh@kernel.org, krzk+dt@kernel.org, jic23@kernel.org,
	dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	conor+dt@kernel.org, mranostay@gmail.com, wbg@kernel.org
Cc: ~lkcamp/patches@lists.sr.ht, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: proximity: Add Lidar-lite-v2 and v3
Date: Thu, 6 Nov 2025 21:34:50 -0300	[thread overview]
Message-ID: <c39a2980-f5e5-44aa-9fd3-20e0658f62dc@gmail.com> (raw)
In-Reply-To: <d30dc192-e37d-49d6-97c7-26e90a7ae6f9@kernel.org>

On 11/3/25 05:04, Krzysztof Kozlowski wrote:
> On 02/11/2025 23:10, Rodrigo Gobbi wrote:
>> Since v2 is not a trivial device, add it to a dedicated place. The v3 is
> 
> What is v2 and v3? This patchset is v3, don't refer to it in the commit
> msg. If you speak about devices then make it obvious. How anyone going
> through `git log` can figure out what is v2. Your patch mentions some v2
> and v3 but these are different companies, so somehow completely
> different products?

Sorry for the commit msg, I`ll make it more clear in this case. About different companies, yes,
that is true. It turns out that this is a "special" case because lidar-lite-v2
chipset was manufactured by Pulsedlight vendor. In other hand, the new version from
it, v3, was manufactured by Garmin, which acquired the Pulsedlight.

In previous versions of this patch I`ve reviewed both datasheets, and the pin-out 
is almost the same, that`s why I`ve added in the same binding.

Probably I`ll send a new patch version without using a patchset as pointed here and fixing the
subject/commit msg to make it more clear.

Feel free to suggest anything else or other concerns.
Tks and regards!!! 


  reply	other threads:[~2025-11-07  0:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-02 22:10 [PATCH v3 0/2] iio: proximity: update Lidar-lite v2 and create v3 Rodrigo Gobbi
2025-11-02 22:10 ` [PATCH v3 1/2] dt-bindings: iio: proximity: Remove Lidar-lite-v2 from trivial Rodrigo Gobbi
2025-11-03  8:00   ` Krzysztof Kozlowski
2025-11-02 22:10 ` [PATCH v3 2/2] dt-bindings: iio: proximity: Add Lidar-lite-v2 and v3 Rodrigo Gobbi
2025-11-03  8:04   ` Krzysztof Kozlowski
2025-11-07  0:34     ` Rodrigo Gobbi [this message]
2025-11-03  7:59 ` [PATCH v3 0/2] iio: proximity: update Lidar-lite v2 and create v3 Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c39a2980-f5e5-44aa-9fd3-20e0658f62dc@gmail.com \
    --to=rodrigo.gobbi.7@gmail.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mranostay@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=wbg@kernel.org \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®