mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: CVE-2023-53027: erofs: fix kvcalloc() misuse with __GFP_NOFAIL
       [not found] <2025032719-CVE-2023-53027-dc56@gregkh>
@ 2025-03-28  6:43 ` Gao Xiang
  2025-03-28  6:53   ` Greg Kroah-Hartman
  0 siblings, 1 reply; 3+ messages in thread
From: Gao Xiang @ 2025-03-28  6:43 UTC (permalink / raw)
  To: cve, linux-kernel, linux-cve-announce; +Cc: Greg Kroah-Hartman

Hi,

On 2025/3/28 00:44, Greg Kroah-Hartman wrote:
> Description
> ===========
> 
> In the Linux kernel, the following vulnerability has been resolved:
> 
> erofs: fix kvcalloc() misuse with __GFP_NOFAIL
> 
> As reported by syzbot [1], kvcalloc() cannot work with  __GFP_NOFAIL.
> Let's use kcalloc() instead.
> 
> [1] https://lore.kernel.org/r/0000000000007796bd05f1852ec2@google.com
> 
> The Linux kernel CVE team has assigned CVE-2023-53027 to this issue.

I think this CVE is invalid since it was then reverted by
upstream commit 647dd2c3f0e1 ("erofs: Revert "erofs: fix kvcalloc()
misuse with __GFP_NOFAIL"")

since it's not the correct way to fix this.

The original issue was fixed by
commit e9c3cda4d86e ("mm, vmalloc: fix high order __GFP_NOFAIL
allocations") instead.

Thanks,
Gao Xiang

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: CVE-2023-53027: erofs: fix kvcalloc() misuse with __GFP_NOFAIL
  2025-03-28  6:43 ` CVE-2023-53027: erofs: fix kvcalloc() misuse with __GFP_NOFAIL Gao Xiang
@ 2025-03-28  6:53   ` Greg Kroah-Hartman
  2025-03-28  6:55     ` Gao Xiang
  0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2025-03-28  6:53 UTC (permalink / raw)
  To: Gao Xiang; +Cc: cve, linux-kernel, linux-cve-announce

On Fri, Mar 28, 2025 at 02:43:04PM +0800, Gao Xiang wrote:
> Hi,
> 
> On 2025/3/28 00:44, Greg Kroah-Hartman wrote:
> > Description
> > ===========
> > 
> > In the Linux kernel, the following vulnerability has been resolved:
> > 
> > erofs: fix kvcalloc() misuse with __GFP_NOFAIL
> > 
> > As reported by syzbot [1], kvcalloc() cannot work with  __GFP_NOFAIL.
> > Let's use kcalloc() instead.
> > 
> > [1] https://lore.kernel.org/r/0000000000007796bd05f1852ec2@google.com
> > 
> > The Linux kernel CVE team has assigned CVE-2023-53027 to this issue.
> 
> I think this CVE is invalid since it was then reverted by
> upstream commit 647dd2c3f0e1 ("erofs: Revert "erofs: fix kvcalloc()
> misuse with __GFP_NOFAIL"")
> 
> since it's not the correct way to fix this.

Ah, that commit was not in the "normal" revert style, which is why we
didn't notice that.

I've now rejected this CVE id, thanks for letting us know!

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: CVE-2023-53027: erofs: fix kvcalloc() misuse with __GFP_NOFAIL
  2025-03-28  6:53   ` Greg Kroah-Hartman
@ 2025-03-28  6:55     ` Gao Xiang
  0 siblings, 0 replies; 3+ messages in thread
From: Gao Xiang @ 2025-03-28  6:55 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: cve, linux-kernel, linux-cve-announce



On 2025/3/28 14:53, Greg Kroah-Hartman wrote:
> On Fri, Mar 28, 2025 at 02:43:04PM +0800, Gao Xiang wrote:
>> Hi,
>>
>> On 2025/3/28 00:44, Greg Kroah-Hartman wrote:
>>> Description
>>> ===========
>>>
>>> In the Linux kernel, the following vulnerability has been resolved:
>>>
>>> erofs: fix kvcalloc() misuse with __GFP_NOFAIL
>>>
>>> As reported by syzbot [1], kvcalloc() cannot work with  __GFP_NOFAIL.
>>> Let's use kcalloc() instead.
>>>
>>> [1] https://lore.kernel.org/r/0000000000007796bd05f1852ec2@google.com
>>>
>>> The Linux kernel CVE team has assigned CVE-2023-53027 to this issue.
>>
>> I think this CVE is invalid since it was then reverted by
>> upstream commit 647dd2c3f0e1 ("erofs: Revert "erofs: fix kvcalloc()
>> misuse with __GFP_NOFAIL"")
>>
>> since it's not the correct way to fix this.
> 
> Ah, that commit was not in the "normal" revert style, which is why we
> didn't notice that.

Yeah, that is somewhat awkward.. Anyway, backport this incorrect
fix due to a CVE just makes it worse.

> 
> I've now rejected this CVE id, thanks for letting us know!

Thanks!

Thanks,
Gao Xiang

> 
> greg k-h


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-03-28  6:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <2025032719-CVE-2023-53027-dc56@gregkh>
2025-03-28  6:43 ` CVE-2023-53027: erofs: fix kvcalloc() misuse with __GFP_NOFAIL Gao Xiang
2025-03-28  6:53   ` Greg Kroah-Hartman
2025-03-28  6:55     ` Gao Xiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®