Re: [PATCH v2 4/5] drm/msm/dpu: drop TE2 definitions

[Abhinav Kumar <quic_abhinavk@quicinc.com>]

On 4/29/2025 5:16 AM, Dmitry Baryshkov wrote:
> On Mon, Apr 28, 2025 at 06:33:05PM -0700, Abhinav Kumar wrote:
>>
>>
>> On 3/1/2025 1:24 AM, Dmitry Baryshkov wrote:
>>> Neither DPU driver nor vendor SDE driver do not use TE2 definitions
>>> (and, in case of SDE driver, never did). Semantics of the TE2 feature
>>> bit and .te2 sblk are not completely clear. Drop these bits from the
>>> catalog with the possibility of reintroducing them later if we need to
>>> support ppsplit.
>>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>>>    drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h |  8 ++++----
>>>    drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h |  8 ++++----
>>>    drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_2_sdm660.h  |  8 ++++----
>>>    drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h  |  4 ++--
>>>    drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h  |  8 ++++----
>>>    drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c          | 17 -----------------
>>>    drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h          |  6 +-----
>>>    7 files changed, 19 insertions(+), 40 deletions(-)
>>>
>>
>> <snip>
>>
>>> @@ -465,22 +459,11 @@ static const struct dpu_dspp_sub_blks sdm845_dspp_sblk = {
>>>    /*************************************************************
>>>     * PINGPONG sub blocks config
>>>     *************************************************************/
>>> -static const struct dpu_pingpong_sub_blks msm8996_pp_sblk_te = {
>>> -	.te2 = {.name = "te2", .base = 0x2000, .len = 0x0,
>>> -		.version = 0x1},
>>> -};
>>>    static const struct dpu_pingpong_sub_blks msm8996_pp_sblk = {
>>>    	/* No dither block */
>>>    };
>>> -static const struct dpu_pingpong_sub_blks sdm845_pp_sblk_te = {
>>> -	.te2 = {.name = "te2", .base = 0x2000, .len = 0x0,
>>> -		.version = 0x1},
>>> -	.dither = {.name = "dither", .base = 0x30e0,
>>> -		.len = 0x20, .version = 0x10000},
>>> -};
>>> -
>>
>> Agreed about TE2. I do not see even te2 sub-block programming in
>> dpu_hw_pingpong but why do we also need to drop dither?
> 
> sdm845_pp_sblk has the dither block. If you scroll the original patch,
> you'd see PPs being switched to that sblk definition.
> 

Ack,

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>