* [PATCH] wifi: ata: pata_parport: epat.c Added missing spaces
[not found] <tencent_DAE8C1D6AAA3633E096977B14E5133F42705@qq.com>
@ 2023-07-18 7:57 ` hanyu001
2023-07-18 8:00 ` Damien Le Moal
2023-07-18 9:15 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: hanyu001 @ 2023-07-18 7:57 UTC (permalink / raw)
To: dlemoal; +Cc: linux-ide, linux-kernel
Added spaces needed in the proper places to address:
./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around
that '=' (ctx:VxV)
./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that
';' (ctx:VxV)
./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around
that '<' (ctx:VxV)
./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that
';' (ctx:VxV)
Signed-off-by: Yu Han <hanyu001@208suo.com>
---
drivers/ata/pata_parport/epat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_parport/epat.c
b/drivers/ata/pata_parport/epat.c
index 016bd96..efc18e2 100644
--- a/drivers/ata/pata_parport/epat.c
+++ b/drivers/ata/pata_parport/epat.c
@@ -280,7 +280,7 @@ static int epat_test_proto(struct pi_adapter *pi)
epat_disconnect(pi);
epat_connect(pi);
- for (j=0;j<2;j++) {
+ for (j = 0; j < 2; j++) {
WRi(6, 0xa0 + j * 0x10);
for (k = 0; k < 256; k++) {
WRi(2, k ^ 0xaa);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: ata: pata_parport: epat.c Added missing spaces
2023-07-18 7:57 ` [PATCH] wifi: ata: pata_parport: epat.c Added missing spaces hanyu001
@ 2023-07-18 8:00 ` Damien Le Moal
2023-07-18 9:15 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2023-07-18 8:00 UTC (permalink / raw)
To: hanyu001; +Cc: linux-ide, linux-kernel
On 7/18/23 16:57, hanyu001@208suo.com wrote:
> Added spaces needed in the proper places to address:
wifi ? I do not think so. Please fix the patch title.
>
> ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around
> that '=' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that
> ';' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around
> that '<' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that
> ';' (ctx:VxV)
>
> Signed-off-by: Yu Han <hanyu001@208suo.com>
> ---
> drivers/ata/pata_parport/epat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_parport/epat.c
> b/drivers/ata/pata_parport/epat.c
> index 016bd96..efc18e2 100644
> --- a/drivers/ata/pata_parport/epat.c
> +++ b/drivers/ata/pata_parport/epat.c
> @@ -280,7 +280,7 @@ static int epat_test_proto(struct pi_adapter *pi)
> epat_disconnect(pi);
>
> epat_connect(pi);
> - for (j=0;j<2;j++) {
> + for (j = 0; j < 2; j++) {
> WRi(6, 0xa0 + j * 0x10);
> for (k = 0; k < 256; k++) {
> WRi(2, k ^ 0xaa);
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: ata: pata_parport: epat.c Added missing spaces
2023-07-18 7:57 ` [PATCH] wifi: ata: pata_parport: epat.c Added missing spaces hanyu001
2023-07-18 8:00 ` Damien Le Moal
@ 2023-07-18 9:15 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2023-07-18 9:15 UTC (permalink / raw)
To: hanyu001, dlemoal; +Cc: linux-ide, linux-kernel
On 7/18/23 10:57 AM, hanyu001@208suo.com wrote:
> Added spaces needed in the proper places to address:
>
> ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around that '=' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that ';' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around that '<' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that ';' (ctx:VxV)
Is that from checkpatch.pl?
> Signed-off-by: Yu Han <hanyu001@208suo.com>
Aside from the issue with the subject:
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
MBR, Sergey
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-18 9:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tencent_DAE8C1D6AAA3633E096977B14E5133F42705@qq.com>
2023-07-18 7:57 ` [PATCH] wifi: ata: pata_parport: epat.c Added missing spaces hanyu001
2023-07-18 8:00 ` Damien Le Moal
2023-07-18 9:15 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®