From: Jeff Layton <jlayton@kernel.org>
To: Maria Sheikh <mariasheikh812@gmail.com>,
cel@kernel.org, neil@brown.name, okorniev@redhat.com,
Dai.Ngo@oracle.com, tom@talpey.com, rostedt@goodmis.org,
mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
trond.myklebust@primarydata.com, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Cc: outreachy@lists.linux.dev, julianbraha@gmail.com
Subject: Re: [PATCH] sunrpc: Remove unused rpc_socket_reset_connection tracepoint
Date: Sun, 08 Nov 2026 07:48:13 -0500 [thread overview]
Message-ID: <c44435291fe8c2116fd84795f2ebb3045d18559e.camel@kernel.org> (raw)
In-Reply-To: <20261108024943.8130-2-mariasheikh812@gmail.com>
On Sun, 2026-11-08 at 07:49 +0500, Maria Sheikh wrote:
> Tracepoint definitions consume kernel memory even when they are not
> used. The rpc_socket_reset_connection tracepoint has had no callers
> since commit 4efdd92c9211 ("SUNRPC: Remove TCP client connection reset
> hack") removed the code that used it, but its definition was left
> behind.
> Remove unused definition. This reduces the size of sunrpc.ko by 628
> bytes.
>
> Fixes: 4efdd92c9211 ("SUNRPC: Remove TCP client connection reset hack")
> Signed-off-by: Maria Sheikh <mariasheikh812@gmail.com>
> ---
> include/trace/events/sunrpc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/trace/events/sunrpc.h b/include/trace/events/sunrpc.h
> index ff855197880d..a0d02d735a7c 100644
> --- a/include/trace/events/sunrpc.h
> +++ b/include/trace/events/sunrpc.h
> @@ -950,7 +950,6 @@ DECLARE_EVENT_CLASS(xs_socket_event_done,
> DEFINE_RPC_SOCKET_EVENT(rpc_socket_state_change);
> DEFINE_RPC_SOCKET_EVENT_DONE(rpc_socket_connect);
> DEFINE_RPC_SOCKET_EVENT_DONE(rpc_socket_error);
> -DEFINE_RPC_SOCKET_EVENT_DONE(rpc_socket_reset_connection);
> DEFINE_RPC_SOCKET_EVENT(rpc_socket_close);
> DEFINE_RPC_SOCKET_EVENT(rpc_socket_shutdown);
>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2026-11-08 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 2:49 Maria Sheikh
2026-11-08 12:48 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c44435291fe8c2116fd84795f2ebb3045d18559e.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=cel@kernel.org \
--cc=julianbraha@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mariasheikh812@gmail.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=outreachy@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=tom@talpey.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®