* [PATCH] sunrpc: Remove unused rpc_socket_reset_connection tracepoint
@ 2026-11-08 2:49 Maria Sheikh
2026-11-08 12:48 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: Maria Sheikh @ 2026-11-08 2:49 UTC (permalink / raw)
To: cel, jlayton, neil, okorniev, Dai.Ngo, tom, rostedt, mhiramat,
mathieu.desnoyers, trond.myklebust, linux-nfs, linux-kernel,
linux-trace-kernel
Cc: outreachy, julianbraha, Maria Sheikh
Tracepoint definitions consume kernel memory even when they are not
used. The rpc_socket_reset_connection tracepoint has had no callers
since commit 4efdd92c9211 ("SUNRPC: Remove TCP client connection reset
hack") removed the code that used it, but its definition was left
behind.
Remove unused definition. This reduces the size of sunrpc.ko by 628
bytes.
Fixes: 4efdd92c9211 ("SUNRPC: Remove TCP client connection reset hack")
Signed-off-by: Maria Sheikh <mariasheikh812@gmail.com>
---
include/trace/events/sunrpc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/trace/events/sunrpc.h b/include/trace/events/sunrpc.h
index ff855197880d..a0d02d735a7c 100644
--- a/include/trace/events/sunrpc.h
+++ b/include/trace/events/sunrpc.h
@@ -950,7 +950,6 @@ DECLARE_EVENT_CLASS(xs_socket_event_done,
DEFINE_RPC_SOCKET_EVENT(rpc_socket_state_change);
DEFINE_RPC_SOCKET_EVENT_DONE(rpc_socket_connect);
DEFINE_RPC_SOCKET_EVENT_DONE(rpc_socket_error);
-DEFINE_RPC_SOCKET_EVENT_DONE(rpc_socket_reset_connection);
DEFINE_RPC_SOCKET_EVENT(rpc_socket_close);
DEFINE_RPC_SOCKET_EVENT(rpc_socket_shutdown);
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sunrpc: Remove unused rpc_socket_reset_connection tracepoint
2026-11-08 2:49 [PATCH] sunrpc: Remove unused rpc_socket_reset_connection tracepoint Maria Sheikh
@ 2026-11-08 12:48 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2026-11-08 12:48 UTC (permalink / raw)
To: Maria Sheikh, cel, neil, okorniev, Dai.Ngo, tom, rostedt,
mhiramat, mathieu.desnoyers, trond.myklebust, linux-nfs,
linux-kernel, linux-trace-kernel
Cc: outreachy, julianbraha
On Sun, 2026-11-08 at 07:49 +0500, Maria Sheikh wrote:
> Tracepoint definitions consume kernel memory even when they are not
> used. The rpc_socket_reset_connection tracepoint has had no callers
> since commit 4efdd92c9211 ("SUNRPC: Remove TCP client connection reset
> hack") removed the code that used it, but its definition was left
> behind.
> Remove unused definition. This reduces the size of sunrpc.ko by 628
> bytes.
>
> Fixes: 4efdd92c9211 ("SUNRPC: Remove TCP client connection reset hack")
> Signed-off-by: Maria Sheikh <mariasheikh812@gmail.com>
> ---
> include/trace/events/sunrpc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/trace/events/sunrpc.h b/include/trace/events/sunrpc.h
> index ff855197880d..a0d02d735a7c 100644
> --- a/include/trace/events/sunrpc.h
> +++ b/include/trace/events/sunrpc.h
> @@ -950,7 +950,6 @@ DECLARE_EVENT_CLASS(xs_socket_event_done,
> DEFINE_RPC_SOCKET_EVENT(rpc_socket_state_change);
> DEFINE_RPC_SOCKET_EVENT_DONE(rpc_socket_connect);
> DEFINE_RPC_SOCKET_EVENT_DONE(rpc_socket_error);
> -DEFINE_RPC_SOCKET_EVENT_DONE(rpc_socket_reset_connection);
> DEFINE_RPC_SOCKET_EVENT(rpc_socket_close);
> DEFINE_RPC_SOCKET_EVENT(rpc_socket_shutdown);
>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-08 12:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-08 2:49 [PATCH] sunrpc: Remove unused rpc_socket_reset_connection tracepoint Maria Sheikh
2026-11-08 12:48 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®