* [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static
@ 2017-08-16 9:23 Colin King
2017-08-16 15:46 ` David Lechner
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-08-16 9:23 UTC (permalink / raw)
To: David Lechner, David Airlie, dri-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function st7586_pipe_enable is local to the source
and does not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'st7586_pipe_enable' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/tinydrm/st7586.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tinydrm/st7586.c b/drivers/gpu/drm/tinydrm/st7586.c
index 1b39d3fb17f7..e4f88564b18f 100644
--- a/drivers/gpu/drm/tinydrm/st7586.c
+++ b/drivers/gpu/drm/tinydrm/st7586.c
@@ -172,7 +172,7 @@ static const struct drm_framebuffer_funcs st7586_fb_funcs = {
.dirty = st7586_fb_dirty,
};
-void st7586_pipe_enable(struct drm_simple_display_pipe *pipe,
+static void st7586_pipe_enable(struct drm_simple_display_pipe *pipe,
struct drm_crtc_state *crtc_state)
{
struct tinydrm_device *tdev = pipe_to_tinydrm(pipe);
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static
2017-08-16 9:23 [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static Colin King
@ 2017-08-16 15:46 ` David Lechner
2017-08-16 19:54 ` Noralf Trønnes
0 siblings, 1 reply; 3+ messages in thread
From: David Lechner @ 2017-08-16 15:46 UTC (permalink / raw)
To: Colin King, David Airlie, dri-devel; +Cc: kernel-janitors, linux-kernel
On 08/16/2017 04:23 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function st7586_pipe_enable is local to the source
> and does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'st7586_pipe_enable' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Acked-By: David Lechner <david@lechnology.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static
2017-08-16 15:46 ` David Lechner
@ 2017-08-16 19:54 ` Noralf Trønnes
0 siblings, 0 replies; 3+ messages in thread
From: Noralf Trønnes @ 2017-08-16 19:54 UTC (permalink / raw)
To: David Lechner, Colin King, David Airlie, dri-devel
Cc: kernel-janitors, linux-kernel
Den 16.08.2017 17.46, skrev David Lechner:
> On 08/16/2017 04:23 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The function st7586_pipe_enable is local to the source
>> and does not need to be in global scope, so make it static.
>>
>> Cleans up sparse warning:
>> symbol 'st7586_pipe_enable' was not declared. Should it be static?
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>
> Acked-By: David Lechner <david@lechnology.com>
Thanks, applied to drm-misc.
Noralf.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-16 19:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-16 9:23 [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static Colin King
2017-08-16 15:46 ` David Lechner
2017-08-16 19:54 ` Noralf Trønnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®