From: Tejun Heo <tj@kernel.org>
To: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
kernel-dev@igalia.com,
Boris Brezillon <boris.brezillon@collabora.com>,
Bradley Morgan <include@grrlz.net>, Chia-I Wu <olv@google.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Matthew Brost <matthew.brost@intel.com>,
Steven Price <steven.price@arm.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Breno Leitao <leitao@debian.org>
Subject: Re: [RFC v6.1 2/3] workqueue: Add support for real-time workers
Date: Wed, 21 Oct 2026 11:27:41 -1000 [thread overview]
Message-ID: <c46ebed464535b07694a449976cdd27a@kernel.org> (raw)
In-Reply-To: <bd59f9aa-b0d3-474f-8c95-f3763e320638@igalia.com>
Hello, Tvrtko.
On Wed, Oct 21, 2026 at 01:53:01PM +0100, Tvrtko Ursulin wrote:
> +static void
> +sanitize_workqueue_attrs(struct workqueue_struct *wq,
> + struct workqueue_attrs *attrs)
> +{
> + if (wq->flags & WQ_HIGHPRI)
> + attrs->nice = HIGHPRI_NICE_LEVEL;
WQ_HIGHPRI only sets the initial nice level, which can be changed
afterwards, e.g. through sysfs. Forcing it here would silently override such
changes. Maybe keep setting it at allocation instead?
> Could you please confirm (or deny :)) this is what you had in mind?
The rest sounds sane to me, but it's difficult to evaluate without looking
at the patches. Can you please post them?
Thanks.
--
tejun
next prev parent reply other threads:[~2026-10-21 21:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 16:07 [RFC v6 0/3] Realtime workqueues and panthor realtime submission Tvrtko Ursulin
2026-10-01 16:07 ` [RFC v6 1/3] workqueue: Simplify unbound sysfs attribute registration Tvrtko Ursulin
2026-10-02 19:30 ` Tejun Heo
2026-10-01 16:07 ` [RFC v6 2/3] workqueue: Add support for real-time workers Tvrtko Ursulin
2026-10-01 18:48 ` [RFC v6.1 " Tvrtko Ursulin
2026-10-02 19:30 ` Tejun Heo
2026-10-19 10:02 ` Tvrtko Ursulin
2026-10-19 23:40 ` Tejun Heo
2026-10-21 12:53 ` Tvrtko Ursulin
2026-10-21 21:27 ` Tejun Heo [this message]
2026-10-01 16:07 ` [RFC v6 3/3] drm/panthor: Create per queue priority workqueues Tvrtko Ursulin
2026-10-02 19:30 ` Tejun Heo
2026-10-05 13:08 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c46ebed464535b07694a449976cdd27a@kernel.org \
--to=tj@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=include@grrlz.net \
--cc=jiangshanlai@gmail.com \
--cc=kernel-dev@igalia.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=matthew.brost@intel.com \
--cc=olv@google.com \
--cc=steven.price@arm.com \
--cc=tvrtko.ursulin@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®