From: Adrian Hunter <adrian.hunter@intel.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-cadence: include <linux/bits.h> instead of <linux/bitops.h>
Date: Tue, 30 Oct 2018 14:35:33 +0200 [thread overview]
Message-ID: <c4af339a-4f7d-c862-367c-9dde16a27a79@intel.com> (raw)
In-Reply-To: <1540897506-3075-1-git-send-email-yamada.masahiro@socionext.com>
On 30/10/18 1:05 PM, Masahiro Yamada wrote:
> The reason of including <linux/bitops.h> here is just for BIT() and
> GENMASK() macros.
>
> Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
> macros from <linux/bitops.h> to a new <linux/bits.h> file"),
> <linux/bits.h> is enough for such compile-time macros.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>
> drivers/mmc/host/sdhci-cadence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
> index 7a343b8..e241287 100644
> --- a/drivers/mmc/host/sdhci-cadence.c
> +++ b/drivers/mmc/host/sdhci-cadence.c
> @@ -14,7 +14,7 @@
> */
>
> #include <linux/bitfield.h>
> -#include <linux/bitops.h>
> +#include <linux/bits.h>
> #include <linux/iopoll.h>
> #include <linux/module.h>
> #include <linux/mmc/host.h>
>
next prev parent reply other threads:[~2018-10-30 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 11:05 Masahiro Yamada
2018-10-30 12:35 ` Adrian Hunter [this message]
2018-11-19 12:07 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4af339a-4f7d-c862-367c-9dde16a27a79@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®