* [PATCH] mmc: sdhci-cadence: include <linux/bits.h> instead of <linux/bitops.h>
@ 2018-10-30 11:05 Masahiro Yamada
2018-10-30 12:35 ` Adrian Hunter
2018-11-19 12:07 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2018-10-30 11:05 UTC (permalink / raw)
To: linux-mmc, Ulf Hansson, Adrian Hunter; +Cc: Masahiro Yamada, linux-kernel
The reason of including <linux/bitops.h> here is just for BIT() and
GENMASK() macros.
Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
macros from <linux/bitops.h> to a new <linux/bits.h> file"),
<linux/bits.h> is enough for such compile-time macros.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/mmc/host/sdhci-cadence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
index 7a343b8..e241287 100644
--- a/drivers/mmc/host/sdhci-cadence.c
+++ b/drivers/mmc/host/sdhci-cadence.c
@@ -14,7 +14,7 @@
*/
#include <linux/bitfield.h>
-#include <linux/bitops.h>
+#include <linux/bits.h>
#include <linux/iopoll.h>
#include <linux/module.h>
#include <linux/mmc/host.h>
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-cadence: include <linux/bits.h> instead of <linux/bitops.h>
2018-10-30 11:05 [PATCH] mmc: sdhci-cadence: include <linux/bits.h> instead of <linux/bitops.h> Masahiro Yamada
@ 2018-10-30 12:35 ` Adrian Hunter
2018-11-19 12:07 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2018-10-30 12:35 UTC (permalink / raw)
To: Masahiro Yamada, linux-mmc, Ulf Hansson; +Cc: linux-kernel
On 30/10/18 1:05 PM, Masahiro Yamada wrote:
> The reason of including <linux/bitops.h> here is just for BIT() and
> GENMASK() macros.
>
> Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
> macros from <linux/bitops.h> to a new <linux/bits.h> file"),
> <linux/bits.h> is enough for such compile-time macros.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>
> drivers/mmc/host/sdhci-cadence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
> index 7a343b8..e241287 100644
> --- a/drivers/mmc/host/sdhci-cadence.c
> +++ b/drivers/mmc/host/sdhci-cadence.c
> @@ -14,7 +14,7 @@
> */
>
> #include <linux/bitfield.h>
> -#include <linux/bitops.h>
> +#include <linux/bits.h>
> #include <linux/iopoll.h>
> #include <linux/module.h>
> #include <linux/mmc/host.h>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-cadence: include <linux/bits.h> instead of <linux/bitops.h>
2018-10-30 11:05 [PATCH] mmc: sdhci-cadence: include <linux/bits.h> instead of <linux/bitops.h> Masahiro Yamada
2018-10-30 12:35 ` Adrian Hunter
@ 2018-11-19 12:07 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2018-11-19 12:07 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-mmc, Adrian Hunter, Linux Kernel Mailing List
On 30 October 2018 at 12:05, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> The reason of including <linux/bitops.h> here is just for BIT() and
> GENMASK() macros.
>
> Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
> macros from <linux/bitops.h> to a new <linux/bits.h> file"),
> <linux/bits.h> is enough for such compile-time macros.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
>
> drivers/mmc/host/sdhci-cadence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
> index 7a343b8..e241287 100644
> --- a/drivers/mmc/host/sdhci-cadence.c
> +++ b/drivers/mmc/host/sdhci-cadence.c
> @@ -14,7 +14,7 @@
> */
>
> #include <linux/bitfield.h>
> -#include <linux/bitops.h>
> +#include <linux/bits.h>
> #include <linux/iopoll.h>
> #include <linux/module.h>
> #include <linux/mmc/host.h>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-19 12:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30 11:05 [PATCH] mmc: sdhci-cadence: include <linux/bits.h> instead of <linux/bitops.h> Masahiro Yamada
2018-10-30 12:35 ` Adrian Hunter
2018-11-19 12:07 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®