From: Jeremy Clifton <deaner92@yahoo.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Viresh Kumar <vireshk@kernel.org>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy@lists.linux.dev, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: Remove unused header declaration to_fw_mgmt_connection
Date: Wed, 14 Oct 2026 16:22:10 -0600 [thread overview]
Message-ID: <c4c3cfb5-1933-484a-8ad4-acff8dacd178@yahoo.com> (raw)
In-Reply-To: <377d4e4f-93bd-6634-c3c5-1113f5057e2@inria.fr>
On 10/14/26 1:13 PM, Julia Lawall wrote:
>
>
> On Wed, 14 Oct 2026, Jeremy Dean Clifton wrote:
>
>> commit 3228900f80c2
>> ("staging: greybus: Remove unused function 'to_fw_mgmt_connection'")
>
> What is this?
>
This is the previous commit that did not remove the prototype of the
function it removed. I'll include a sentence explaining what this commit
info is here for.
>>
>> Function header declaration needs to be removed after it's declaration.
>
> it's -> its
>
This is a grammar and semantic error on my part. First, you are correct
about 'its.'
Second, the word 'declaration' is truly not correct here. It would read
better as 'definition.'
"Function header declaration needs to be removed after definition removal."
Submitting v2 with corrections.
Jeremy
prev parent reply other threads:[~2026-10-14 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261014171342.97160-1-deaner92.ref@yahoo.com>
2026-10-14 17:13 ` Jeremy Dean Clifton
2026-10-14 19:13 ` Julia Lawall
2026-10-14 22:22 ` Jeremy Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4c3cfb5-1933-484a-8ad4-acff8dacd178@yahoo.com \
--to=deaner92@yahoo.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®