[PATCH] staging: greybus: Remove unused header declaration to_fw_mgmt_connection

[PATCH] staging: greybus: Remove unused header declaration to_fw_mgmt_connection

[Jeremy Dean Clifton]

commit 3228900f80c2
("staging: greybus: Remove unused function 'to_fw_mgmt_connection'")

Function header declaration needs to be removed after it's declaration.
There is no declaration of this function nor is there any place where it
is called.

Signed-off-by: Jeremy Dean Clifton <deaner92@yahoo.com>
---
 drivers/staging/greybus/firmware.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h
index 5d2564462ffc..04a67d2d5b8f 100644
--- a/drivers/staging/greybus/firmware.h
+++ b/drivers/staging/greybus/firmware.h
@@ -22,7 +22,6 @@
 /* Firmware Management Protocol specific functions */
 int fw_mgmt_init(void);
 void fw_mgmt_exit(void);
-struct gb_connection *to_fw_mgmt_connection(struct device *dev);
 int gb_fw_mgmt_request_handler(struct gb_operation *op);
 int gb_fw_mgmt_connection_init(struct gb_connection *connection);
 void gb_fw_mgmt_connection_exit(struct gb_connection *connection);
-- 
2.43.0

Re: [PATCH] staging: greybus: Remove unused header declaration to_fw_mgmt_connection

[Julia Lawall]

On Wed, 14 Oct 2026, Jeremy Dean Clifton wrote:

> commit 3228900f80c2
> ("staging: greybus: Remove unused function 'to_fw_mgmt_connection'")

What is this?

>
> Function header declaration needs to be removed after it's declaration.

it's -> its

But I don't really understand the sentence.

julia

> There is no declaration of this function nor is there any place where it
> is called.
>
> Signed-off-by: Jeremy Dean Clifton <deaner92@yahoo.com>
> ---
>  drivers/staging/greybus/firmware.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h
> index 5d2564462ffc..04a67d2d5b8f 100644
> --- a/drivers/staging/greybus/firmware.h
> +++ b/drivers/staging/greybus/firmware.h
> @@ -22,7 +22,6 @@
>  /* Firmware Management Protocol specific functions */
>  int fw_mgmt_init(void);
>  void fw_mgmt_exit(void);
> -struct gb_connection *to_fw_mgmt_connection(struct device *dev);
>  int gb_fw_mgmt_request_handler(struct gb_operation *op);
>  int gb_fw_mgmt_connection_init(struct gb_connection *connection);
>  void gb_fw_mgmt_connection_exit(struct gb_connection *connection);
> --
> 2.43.0
>
>
>

Re: [PATCH] staging: greybus: Remove unused header declaration to_fw_mgmt_connection

[Jeremy Clifton]

On 10/14/26 1:13 PM, Julia Lawall wrote:
> 
> 
> On Wed, 14 Oct 2026, Jeremy Dean Clifton wrote:
> 
>> commit 3228900f80c2
>> ("staging: greybus: Remove unused function 'to_fw_mgmt_connection'")
> 
> What is this?
> 

This is the previous commit that did not remove the prototype of the 
function it removed. I'll include a sentence explaining what this commit 
info is here for.
>>
>> Function header declaration needs to be removed after it's declaration.
> 
> it's -> its
> 

This is a grammar and semantic error on my part. First, you are correct 
about 'its.'
Second, the word 'declaration' is truly not correct here. It would read 
better as 'definition.'

"Function header declaration needs to be removed after definition removal."

Submitting v2 with corrections.

Jeremy