mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	Heiko Schocher <hs@denx.de>,
	linux-can@vger.kernel.org
Cc: Markus Marb <markus@marb.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error
Date: Thu, 8 Feb 2018 22:44:58 +0100	[thread overview]
Message-ID: <c4d4f09b-42c2-90b3-65b2-4b493262c649@denx.de> (raw)
In-Reply-To: <ca1b9134-1e5a-ea83-146f-693ba38be413@pengutronix.de>

On 02/08/2018 10:33 PM, Marc Kleine-Budde wrote:
> On 02/08/2018 08:22 PM, Marek Vasut wrote:
>> On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote:
>>> On 02/08/2018 07:47 AM, Heiko Schocher wrote:
>>>> the driver reads in the ISR first the IRQpending register,
>>>> and clears after that in a write *all* bits in it.
>>>>
>>>> It could happen that the isr register raise bits between
>>>> this 2 register accesses, which leads in lost bits ...
>>>>
>>>> In case it clears "TX message sent successfully", the driver
>>>> never sends any Tx data, and buffers to userspace run over.
>>>>
>>>> Fixed this:
>>>> clear only the bits in the IRQpending register, the
>>>> driver had read.
>>>>
>>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>>> Reviewed-by: Marek Vasut <marex@denx.de>
>>>
>>> Applied both to linux-can.
>>
>> Can you also apply them to stable, so they get into 4.9.x etc ?
> 
> I've already added stable on Cc, so they will be picked up by the stable
> maintainers.

Thanks!

-- 
Best regards,
Marek Vasut

      reply	other threads:[~2018-02-08 21:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-08  6:47 Heiko Schocher
2018-02-08  6:47 ` [PATCH v2 2/2] net, can, ifi: loopback Tx message in IFI block Heiko Schocher
2018-02-08 14:46 ` [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error Marc Kleine-Budde
2018-02-08 19:22   ` Marek Vasut
2018-02-08 21:33     ` Marc Kleine-Budde
2018-02-08 21:44       ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4d4f09b-42c2-90b3-65b2-4b493262c649@denx.de \
    --to=marex@denx.de \
    --cc=hs@denx.de \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@marb.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®