From: Andrew Lunn <andrew@lunn.ch>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
davem@davemloft.net, "Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
"Simon Horman" <horms@kernel.org>,
"Boon Khai Ng" <boon.khai.ng@altera.com>,
"Alexis Lothoré" <alexis.lothore@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] net: altera-tse: Init PCS and phylink before registering netdev
Date: Fri, 31 Oct 2025 17:19:20 +0100 [thread overview]
Message-ID: <c4e3dc1c-e730-4240-860b-426da10840c4@lunn.ch> (raw)
In-Reply-To: <20251030102418.114518-5-maxime.chevallier@bootlin.com>
On Thu, Oct 30, 2025 at 11:24:17AM +0100, Maxime Chevallier wrote:
> register_netdev() must be done only once all resources are ready, as
> they may be used in .ndo_open() immediately upon registration.
>
> Move the lynx PCS and phylink initialisation before registerng the
> netdevice. We also remove the call to netif_carrier_off(), as phylink
> takes care of that.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2025-10-31 16:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 10:24 [PATCH net-next 0/4] net: altera-tse: Cleanup init sequence Maxime Chevallier
2025-10-30 10:24 ` [PATCH net-next 1/4] net: altera-tse: Set platform drvdata before registering netdev Maxime Chevallier
2025-10-31 16:08 ` Andrew Lunn
2025-10-30 10:24 ` [PATCH net-next 2/4] net: altera-tse: Read core revision " Maxime Chevallier
2025-10-31 16:15 ` Andrew Lunn
2025-10-31 16:32 ` Maxime Chevallier
2025-10-30 10:24 ` [PATCH net-next 3/4] net: altera-tse: Don't use netdev name for the PCS mdio bus Maxime Chevallier
2025-10-31 16:17 ` Andrew Lunn
2025-10-30 10:24 ` [PATCH net-next 4/4] net: altera-tse: Init PCS and phylink before registering netdev Maxime Chevallier
2025-10-31 16:19 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4e3dc1c-e730-4240-860b-426da10840c4@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexis.lothore@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=boon.khai.ng@altera.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®