From: Andy Lutomirski <luto@kernel.org>
To: Mario Limonciello <mario.limonciello@dell.com>, dvhart@infradead.org
Cc: LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org, quasisec@google.com,
pali.rohar@gmail.com
Subject: Re: [PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI interface
Date: Wed, 27 Sep 2017 12:47:54 -0700 [thread overview]
Message-ID: <c50c7b2a-7e91-a337-2442-6f0b60875491@kernel.org> (raw)
In-Reply-To: <4da87eb0d9722ed906615409586a8b4d7becd65c.1505999739.git.mario.limonciello@dell.com>
On 09/21/2017 06:57 AM, Mario Limonciello wrote:
> The driver currently uses an SMI interface which grants direct access
> to physical memory to the platform via a pointer.
>
> Changing this to operate over WMI-ACPI will use an ACPI OperationRegion
> for a buffer of data storage when platform calls are performed.
>
> This is a safer approach to use in kernel drivers as the platform will
> only have access to that OperationRegion.
>
> As a result, this change removes the dependency on this driver on the
> dcdbas kernel module.
>
> + status = wmi_evaluate_method(DELL_WMI_SMBIOS_GUID,
> + 0, 1, &input, &output);
It might be nice to add a wmidev_method_evaluate(struct wmi_device
*wdev, ...) function to better aligh with the new world order. The only
reason I didn't do it is that I didn't convert any drivers that wanted it.
next prev parent reply other threads:[~2017-09-27 19:47 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 13:57 [PATCH 00/12] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-09-21 13:57 ` [PATCH 01/12] platform/x86: dell-wmi: label driver as handling notifications Mario Limonciello
2017-09-25 16:04 ` Pali Rohár
2017-09-25 20:14 ` Mario.Limonciello
2017-09-27 15:43 ` Darren Hart
2017-09-21 13:57 ` [PATCH 02/12] platform/x86: dell-wmi: Don't match on descriptor GUID modalias Mario Limonciello
2017-09-25 16:06 ` Pali Rohár
2017-09-21 13:57 ` [PATCH 03/12] platform/x86: dell-smbios: Add pr_fmt definition to driver Mario Limonciello
2017-09-21 16:22 ` Andy Shevchenko
2017-09-25 16:07 ` Pali Rohár
2017-09-21 13:57 ` [PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI interface Mario Limonciello
2017-09-25 16:18 ` Pali Rohár
2017-09-25 19:28 ` Mario.Limonciello
2017-09-27 16:46 ` Darren Hart
2017-09-27 18:29 ` Mario.Limonciello
2017-09-27 19:47 ` Andy Lutomirski [this message]
2017-09-27 21:15 ` Mario.Limonciello
2017-09-21 13:57 ` [PATCH 05/12] platform/x86: dell-smbios: rename to dell-wmi-smbios Mario Limonciello
2017-09-21 13:57 ` [PATCH 06/12] platform/x86: dell-wmi-smbios: Add a sysfs interface for SMBIOS tokens Mario Limonciello
2017-09-25 16:23 ` Pali Rohár
2017-09-25 17:04 ` Andy Shevchenko
2017-09-25 17:31 ` Mario.Limonciello
2017-09-27 16:50 ` Darren Hart
2017-09-27 18:27 ` Mario.Limonciello
2017-09-27 18:31 ` Andy Shevchenko
2017-09-27 18:55 ` Darren Hart
2017-09-27 19:49 ` Andy Lutomirski
2017-09-27 19:50 ` Mario.Limonciello
2017-09-21 13:57 ` [PATCH 07/12] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check Mario Limonciello
2017-09-21 16:44 ` Andy Shevchenko
2017-09-21 20:56 ` Mario.Limonciello
2017-09-21 13:57 ` [PATCH 08/12] platform/x86: wmi: Cleanup exit routine in reverse order of init Mario Limonciello
2017-09-21 13:57 ` [PATCH 09/12] platform/x86: wmi: create character devices when requested by drivers Mario Limonciello
2017-09-21 16:46 ` Andy Shevchenko
2017-09-21 19:21 ` Mario.Limonciello
2017-09-21 13:57 ` [PATCH 10/12] platform/x86: wmi: destroy on cleanup rather than unregister Mario Limonciello
2017-09-21 13:57 ` [PATCH 11/12] platform/x86: dell-wmi-smbios: introduce character device for userspace Mario Limonciello
2017-09-25 16:31 ` Pali Rohár
2017-09-25 16:58 ` Andy Shevchenko
2017-09-25 17:46 ` Mario.Limonciello
2017-09-27 16:59 ` Darren Hart
2017-09-27 18:10 ` Mario.Limonciello
2017-09-27 18:50 ` Darren Hart
2017-09-27 21:12 ` Mario.Limonciello
2017-09-27 21:59 ` Darren Hart
2017-09-21 13:57 ` [PATCH 12/12] platform/x86: Kconfig: Change the default settings for dell-wmi-smbios Mario Limonciello
2017-09-25 16:13 ` [PATCH 00/12] Introduce support for Dell SMBIOS over WMI Pali Rohár
2017-09-25 16:32 ` Mario.Limonciello
2017-09-25 16:49 ` Pali Rohár
2017-09-25 19:27 ` Mario.Limonciello
2017-09-27 16:39 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c50c7b2a-7e91-a337-2442-6f0b60875491@kernel.org \
--to=luto@kernel.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quasisec@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®