From: Paolo Abeni <pabeni@redhat.com>
To: Diogo Ivo <diogo.ivo@siemens.com>,
MD Danish Anwar <danishanwar@ti.com>,
Roger Quadros <rogerq@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Simon Horman <horms@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: ti: icss-iep: Enable compare events
Date: Thu, 06 Jun 2024 12:32:03 +0200 [thread overview]
Message-ID: <c518f6dd6cf9e92469d37a7317a6881ebed6a8c1.camel@redhat.com> (raw)
In-Reply-To: <20240604-iep-v2-2-ea8e1c0a5686@siemens.com>
On Tue, 2024-06-04 at 14:15 +0100, Diogo Ivo wrote:
> @@ -571,6 +573,57 @@ static int icss_iep_perout_enable(struct icss_iep *iep,
> return ret;
> }
>
> +static void icss_iep_cap_cmp_work(struct work_struct *work)
> +{
> + struct icss_iep *iep = container_of(work, struct icss_iep, work);
> + const u32 *reg_offs = iep->plat_data->reg_offs;
> + struct ptp_clock_event pevent;
> + unsigned int val;
> + u64 ns, ns_next;
> +
> + spin_lock(&iep->irq_lock);
'irq_lock' is always acquired with the irqsave variant, and here we are
in process context. This discrepancy would at least deserve a comment;
likely the above lock type is not correct.
Cheers,
Paolo
next prev parent reply other threads:[~2024-06-06 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 13:15 [PATCH net-next v2 0/3] Enable PTP timestamping/PPS for AM65x SR1.0 devices Diogo Ivo
2024-06-04 13:15 ` [PATCH net-next v2 1/3] net: ti: icssg-prueth: Enable PTP timestamping support for " Diogo Ivo
2024-06-04 14:19 ` Wojciech Drewek
2024-06-04 13:15 ` [PATCH net-next v2 2/3] net: ti: icss-iep: Enable compare events Diogo Ivo
2024-06-04 14:23 ` Wojciech Drewek
2024-06-06 10:32 ` Paolo Abeni [this message]
2024-06-06 13:28 ` Diogo Ivo
2024-06-06 13:49 ` Paolo Abeni
2024-06-06 15:43 ` Diogo Ivo
2024-06-04 13:15 ` [PATCH net-next v2 3/3] arm64: dts: ti: iot2050: Add IEP interrupts for SR1.0 devices Diogo Ivo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c518f6dd6cf9e92469d37a7317a6881ebed6a8c1.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®