From: Jijie Shao <shaojijie@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
<salil.mehta@huawei.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<shenjian15@huawei.com>, <wangjie125@huawei.com>,
<liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/6] net: hns3: add support for page_pool_get_stats
Date: Tue, 12 Dec 2023 19:05:41 +0800 [thread overview]
Message-ID: <c51d3d95-4b59-405f-b5c2-71ccc4dc7cce@huawei.com> (raw)
In-Reply-To: <20231211191759.61764363@kernel.org>
on 2023/12/12 11:17, Jakub Kicinski wrote:
> On Mon, 11 Dec 2023 10:08:11 +0800 Jijie Shao wrote:
>> Add support for page_pool_get_stats, then the hns3 driver
>> can get page pool statistics by ethtool.
> Sorry, you're late to the party :( We have now added the ability to
> read page pool stats via netlink. The support was merged as
> a379972973a80924b1d03443e20f113ff76a94c7.
>
> If you use the page pools in your driver in a normal way (each page
> pool only used by one NAPI instance and one netdev) you should use
> that instead of dumping the stats into ethtool -S.
Okay, we'll try to use netlink instead of ethtool.
And this patch will be dropped in v2 patch set. Jijie
next prev parent reply other threads:[~2023-12-12 11:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 2:08 [PATCH net-next 0/6] There are some features for the HNS3 ethernet driver Jijie Shao
2023-12-11 2:08 ` [PATCH net-next 1/6] net: hns3: add support for page_pool_get_stats Jijie Shao
2023-12-12 3:17 ` Jakub Kicinski
2023-12-12 11:05 ` Jijie Shao [this message]
2023-12-11 2:08 ` [PATCH net-next 2/6] net: hns3: add command queue trace for hns3 Jijie Shao
2023-12-11 2:08 ` [PATCH net-next 3/6] net: hns3: dump more reg info based on ras mod Jijie Shao
2023-12-11 2:08 ` [PATCH net-next 4/6] net: hns3: support dump pfc frame statistics in tx timeout log Jijie Shao
2023-12-11 2:08 ` [PATCH net-next 5/6] net: hns3: Add support for some CMIS transceiver modules Jijie Shao
2023-12-12 3:21 ` Jakub Kicinski
2023-12-12 11:09 ` Jijie Shao
2023-12-13 11:02 ` Ido Schimmel
2023-12-11 2:08 ` [PATCH net-next 6/6] net: sfp: Synchronize some CMIS transceiver modules from ethtool Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c51d3d95-4b59-405f-b5c2-71ccc4dc7cce@huawei.com \
--to=shaojijie@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®