From: Dmitry Safonov <dima@arista.com>
To: Simon Horman <horms@kernel.org>
Cc: David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Ard Biesheuvel <ardb@kernel.org>,
Bob Gilligan <gilligan@arista.com>,
Dan Carpenter <error27@gmail.com>,
David Laight <David.Laight@aculab.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Donald Cassidy <dcassidy@redhat.com>,
Eric Biggers <ebiggers@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Francesco Ruggeri <fruggeri05@gmail.com>,
"Gaillardetz, Dominik" <dgaillar@ciena.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Ivan Delalande <colona@arista.com>,
Leonard Crestez <cdleonard@gmail.com>,
"Nassiri, Mohammad" <mnassiri@ciena.com>,
Salam Noureddine <noureddine@arista.com>,
Simon Horman <simon.horman@corigine.com>,
"Tetreault, Francois" <ftetreau@ciena.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v10 net-next 09/23] net/tcp: Add TCP-AO sign to twsk
Date: Tue, 5 Sep 2023 21:07:18 +0100 [thread overview]
Message-ID: <c522dfe0-207e-a005-452c-552d3663d413@arista.com> (raw)
In-Reply-To: <ZNy7A17n3BrMuh1b@vergenet.net>
On 8/16/23 13:03, Simon Horman wrote:
> On Tue, Aug 15, 2023 at 08:14:38PM +0100, Dmitry Safonov wrote:
>
> ...
>
>> @@ -1183,6 +1216,7 @@ static void tcp_v6_reqsk_send_ack(const struct sock *sk, struct sk_buff *skb,
>> ipv6_get_dsfield(ipv6_hdr(skb)), 0,
>> READ_ONCE(sk->sk_priority),
>> READ_ONCE(tcp_rsk(req)->txhash));
>> + NULL, NULL, 0, 0);
>
> Hi Dmitry,
>
> This seems to add a syntax error.
>
> ...
Rectified by "net/tcp: Wire TCP-AO to request sockets".
Likely, an artifact from the rebase over READ_ONCE() for txhash.
I will correct it in v11, thanks for noticing!
--
Dmitry
next prev parent reply other threads:[~2023-09-05 20:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 19:14 [PATCH v10 net-next 00/23] net/tcp: Add TCP-AO support Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 01/23] net/tcp: Prepare tcp_md5sig_pool for TCP-AO Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 02/23] net/tcp: Add TCP-AO config and structures Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 03/23] net/tcp: Introduce TCP_AO setsockopt()s Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 04/23] net/tcp: Prevent TCP-MD5 with TCP-AO being set Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 05/23] net/tcp: Calculate TCP-AO traffic keys Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 06/23] net/tcp: Add TCP-AO sign to outgoing packets Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 07/23] net/tcp: Add tcp_parse_auth_options() Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 08/23] net/tcp: Add AO sign to RST packets Dmitry Safonov
2023-08-16 11:50 ` Simon Horman
2023-09-05 20:04 ` Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 09/23] net/tcp: Add TCP-AO sign to twsk Dmitry Safonov
2023-08-16 12:03 ` Simon Horman
2023-09-05 20:07 ` Dmitry Safonov [this message]
2023-08-15 19:14 ` [PATCH v10 net-next 10/23] net/tcp: Wire TCP-AO to request sockets Dmitry Safonov
2023-08-16 19:45 ` Simon Horman
2023-09-05 20:24 ` Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 11/23] net/tcp: Sign SYN-ACK segments with TCP-AO Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 12/23] net/tcp: Verify inbound TCP-AO signed segments Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 13/23] net/tcp: Add TCP-AO segments counters Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 14/23] net/tcp: Add TCP-AO SNE support Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 15/23] net/tcp: Add tcp_hash_fail() ratelimited logs Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 16/23] net/tcp: Ignore specific ICMPs for TCP-AO connections Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 17/23] net/tcp: Add option for TCP-AO to (not) hash header Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 18/23] net/tcp: Add TCP-AO getsockopt()s Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 19/23] net/tcp: Allow asynchronous delete for TCP-AO keys (MKTs) Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 20/23] net/tcp: Add static_key for TCP-AO Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 21/23] net/tcp: Wire up l3index to TCP-AO Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 22/23] net/tcp: Add TCP_AO_REPAIR Dmitry Safonov
2023-08-15 19:14 ` [PATCH v10 net-next 23/23] Documentation/tcp: Add TCP-AO documentation Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c522dfe0-207e-a005-452c-552d3663d413@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=David.Laight@aculab.com \
--cc=ardb@kernel.org \
--cc=cdleonard@gmail.com \
--cc=colona@arista.com \
--cc=davem@davemloft.net \
--cc=dcassidy@redhat.com \
--cc=dgaillar@ciena.com \
--cc=dsahern@kernel.org \
--cc=ebiederm@xmission.com \
--cc=ebiggers@kernel.org \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=fruggeri05@gmail.com \
--cc=ftetreau@ciena.com \
--cc=gilligan@arista.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mnassiri@ciena.com \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®